From a544c37df111a8a2b1fa81afe6e5022988919add Mon Sep 17 00:00:00 2001 From: Tyler Coleman Date: Fri, 17 Jan 2025 10:28:01 -0800 Subject: [PATCH] change to find_or_create_by --- .../sidekiq/claims_api/v2/poa_form_builder_job.rb | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/modules/claims_api/app/sidekiq/claims_api/v2/poa_form_builder_job.rb b/modules/claims_api/app/sidekiq/claims_api/v2/poa_form_builder_job.rb index acda10e6ef6..8d4bd77d7de 100644 --- a/modules/claims_api/app/sidekiq/claims_api/v2/poa_form_builder_job.rb +++ b/modules/claims_api/app/sidekiq/claims_api/v2/poa_form_builder_job.rb @@ -18,15 +18,11 @@ class PoaFormBuilderJob < ClaimsApi::ServiceBase # @param power_of_attorney_id [String] Unique identifier of the submitted POA def perform(power_of_attorney_id, form_number, rep_id, action) # rubocop:disable Metrics/MethodLength power_of_attorney = ClaimsApi::PowerOfAttorney.find(power_of_attorney_id) - process = ClaimsApi::Process.find_by(processable: power_of_attorney, - step_type: 'PDF_SUBMISSION') - if process.nil? - process = ClaimsApi::Process.create!(processable: power_of_attorney, - step_type: 'PDF_SUBMISSION', - step_status: 'IN_PROGRESS') - else - process.update!(step_status: 'IN_PROGRESS') - end + + process = ClaimsApi::Process.find_or_create_by(processable: power_of_attorney, + step_type: 'PDF_SUBMISSION') + process.update!(step_status: 'IN_PROGRESS') + rep = ::Veteran::Service::Representative.where(representative_id: rep_id).order(created_at: :desc).first output_path = pdf_constructor(form_number).construct(data(power_of_attorney, form_number, rep),