From 4639349ef533e630318ac45482f22c631f7c6753 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yunus=20Emre=20Delig=C3=B6z?= Date: Fri, 31 May 2024 10:15:29 +0300 Subject: [PATCH 1/2] fix(TCKimlikNo): switch default of forcePublicApi to true --- src/TCKimlikNo.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/TCKimlikNo.php b/src/TCKimlikNo.php index d741176..313d70f 100644 --- a/src/TCKimlikNo.php +++ b/src/TCKimlikNo.php @@ -28,7 +28,7 @@ public static function validate( bool $autoUppercase = true, null|int|string $birthMonth = null, null|int|string $birthDay = null, - bool $forcePublicApi = false, + bool $forcePublicApi = true, ): bool { if ($autoUppercase) { $name = self::toUppercaseTr($name); From 67a5c2640351c13c3cb623de1a3a7dc91b076e76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yunus=20Emre=20Delig=C3=B6z?= Date: Fri, 31 May 2024 10:15:40 +0300 Subject: [PATCH 2/2] test(TCKimlikNoValidateTest): update validate method test case An additional parameter was added to the validate method in the TCkimlikNoValidateTest to accommodate for changes in the underlying validation logic. Now testing this extended functionality. --- tests/TCKimlikNoValidateTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/TCKimlikNoValidateTest.php b/tests/TCKimlikNoValidateTest.php index c4dd938..dca3ad1 100644 --- a/tests/TCKimlikNoValidateTest.php +++ b/tests/TCKimlikNoValidateTest.php @@ -99,7 +99,7 @@ public function it_sends_a_request_to_the_search_api_if_there_is_a_birth_year_an Soap::fake(); $this->assertTrue( - TCKimlikNo::validate('10000000146', 'Y. EMRE', 'DELİGÖZ', '1900', true, 1, 1) + TCKimlikNo::validate('10000000146', 'Y. EMRE', 'DELİGÖZ', '1900', true, 1, 1, false) ); Soap::assertNothingSent();