Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for limits in qdrant config #269

Open
konrad-czarnota-ds opened this issue Jan 9, 2025 · 0 comments
Open

feat: support for limits in qdrant config #269

konrad-czarnota-ds opened this issue Jan 9, 2025 · 0 comments
Labels
feature New feature or request
Milestone

Comments

@konrad-czarnota-ds
Copy link
Collaborator

I would like to provide additional field to qdrant config in the following way:

type: ragbits.core.vector_stores.qdrant:QdrantVectorStore
config:
  client:
    type: AsyncQdrantClient
    config:
      limits:
        max_keepalive_connections: 0
        keepalive_expiry: 20

The thing is that AsyncQdrantClient expects an object like that:

httpx.Limits(max_connections=None, max_keepalive_connections=0, keepalive_expiry=20)

So we probably need to adjust QdrantVectorStore:from_config method to convert dict to limits object.

It is necessary for me because I'm getting random connection errors from qdrant related to this keepalive feature and need to adjust them.

@ludwiktrammer ludwiktrammer moved this to Ready in ragbits Jan 9, 2025
@ludwiktrammer ludwiktrammer added this to the Ragbits 0.6 milestone Jan 9, 2025
@micpst micpst added the feature New feature or request label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Ready
Development

No branches or pull requests

3 participants