feat: add support to pgvector #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 204b4cb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Trivy scanning results. .venv/lib/python3.10/site-packages/PyJWT-2.9.0.dist-info/METADATA (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: JWT (jwt-token) .venv/lib/python3.10/site-packages/litellm/llms/huggingface/huggingface_llms_metadata/hf_text_generation_models.txt (secrets)Total: 1 (MEDIUM: 0, HIGH: 0, CRITICAL: 1) CRITICAL: HuggingFace (hugging-face-access-token) .venv/lib/python3.10/site-packages/litellm/proxy/_types.py (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: Slack (slack-web-hook) |
packages/ragbits-core/src/ragbits/core/vector_stores/pgvector.py
Outdated
Show resolved
Hide resolved
| metadata_store: The metadata store to use. If None, the metadata will be stored in pgVector db. | ||
| """ | ||
| super().__init__(default_options=default_options, metadata_store=metadata_store) | ||
| conf = PgVectorConfig() |
There was a problem hiding this comment.
This part is confusing to me. If you want to provide default values for some of the __init__ arguments why not just provide the default value in the method signature (e.g., vector_size: int = 512,)?
It also seems to me that the db argument should not have a default value and instead be required.
| create_command = self._create_table_command() | ||
| await conn.execute(create_command) | ||
| hnsw_name = self.table_name + "_hnsw_idx" | ||
| query = create_index_query.format( |
There was a problem hiding this comment.
We should never format SQL queries using string operations - this creates a SQL injection and other problems connected with unexpected characters. You should always pass values the way you did on line 105 - as arguments to the relevant function of the SQL library.
There was a problem hiding this comment.
I've added the check on table name in init
| """ | ||
| distance_operator = PgVectorDistance.DISTANCE_OPS[self.distance_method][1] | ||
|
|
||
| query = f"SELECT * FROM {self.table_name}" # noqa S608 |
There was a problem hiding this comment.
Again, all values added to SQL query via f-string create possibilities for sql injection / bugs connected to characters that has not been escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.