feat: Simplification of Document Search Evaluation interface #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 7bcf23f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Trivy scanning results. .venv/lib/python3.10/site-packages/litellm/llms/huggingface/huggingface_llms_metadata/hf_text_generation_models.txt (secrets)Total: 1 (MEDIUM: 0, HIGH: 0, CRITICAL: 1) CRITICAL: HuggingFace (hugging-face-access-token) .venv/lib/python3.10/site-packages/litellm/proxy/_types.py (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: Slack (slack-web-hook) .venv/lib/python3.10/site-packages/PyJWT-2.9.0.dist-info/METADATA (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: JWT (jwt-token) |
mhordynski
previously approved these changes
Dec 23, 2024
micpst
reviewed
Dec 23, 2024
| @@ -64,11 +65,11 @@ class DocumentSearchWithIngestionPipeline(DocumentSearchPipeline): | |||
|
|
|||
| def __init__(self, config: DictConfig | None = None) -> None: | |||
| super().__init__(config) | |||
| self.config.vector_store.config.index_name = str(uuid.uuid4()) | |||
| # self.config.vector_store.config.index_name = str(uuid.uuid4()) | |||
| args: | ||
| callback_type: neptune.integrations.optuna:NeptuneCallback | ||
| project: deepsense-ai/ragbits | ||
| #callbacks: |
There was a problem hiding this comment.
becaus i've wanted to switch off neptune by default - added a comment with information
| module = sys.modules[__name__] | ||
|
|
||
|
|
||
| def pipeline_factory(pipeline_config: DictConfig) -> EvaluationPipeline: |
There was a problem hiding this comment.
maybe we can leverage new WithConstructionConfig class here, same applies for merics and dataloaders factories
There was a problem hiding this comment.
i would prefer to create new ticket for this
| """ | ||
| Function running evaluation for all datasets and evaluation tasks defined in config. | ||
| """ | ||
| config = OmegaConf.create( |
There was a problem hiding this comment.
do we have to wrap these configs with hydra?
There was a problem hiding this comment.
actually we have a few lines where config object is used like that:
max_retries = getattr(self.config, "max_retries_for_trial", 1)
if we had switched to dictionary - it would throw an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.