Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download with SAS token from front end #3

Open
QuadmanSWE opened this issue Apr 5, 2024 · 4 comments
Open

Download with SAS token from front end #3

QuadmanSWE opened this issue Apr 5, 2024 · 4 comments

Comments

@QuadmanSWE
Copy link

Rather than the backend downloading the file and then streaming it to the front end it could be preferable to download directly from the client using a SAS token that the backend generates.

I can get started on building this if you want.

@QuadmanSWE
Copy link
Author

We don't really need it to work from the front end, we are imagining we will either build our own fork of it or reuse a previous plugin we have. But we were interested in the blob storage interactions of your plugin.

Here is what it looks like when I tried my link generation out in your front end plugin. What do you think?

image

@QuadmanSWE
Copy link
Author

QuadmanSWE commented Apr 5, 2024

Here is my branch on it: https://github.com/QuadmanSWE/deepan10-backstage-plugins/tree/directDownloadFromAzure
I rebased off of your new release and made a new branch that I connected on the PR. Linked below...

@deepan10
Copy link
Owner

deepan10 commented Apr 5, 2024

@QuadmanSWE
Awesome 🚀 It's a nice idea to use the SAS token and download it from the Azure Storage account itself. We can remove the Backend download and use the Direct Azure download. Please feel free to raise a PR will ship this out 👍.

@QuadmanSWE
Copy link
Author

@QuadmanSWE Awesome 🚀 It's a nice idea to use the SAS token and download it from the Azure Storage account itself. We can remove the Backend download and use the Direct Azure download. Please feel free to raise a PR will ship this out 👍.

It only works if the backend is allowed to generate the sas token though, and the function from microsoft only works if the credentials are of the correct type.

I will need some help with code review to make sure that the changes I am proposing works as intended.

I will still create the PR but I will ping you there so that we can review together when you have the time. Im in CET timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants