From fb29d682b76d3968439caef8c42d2fd67838a310 Mon Sep 17 00:00:00 2001
From: Jochen <rothjochen@gmail.com>
Date: Mon, 16 Dec 2024 20:42:54 +0100
Subject: [PATCH] [TASK] Add DDEV HEAD (aka nightly, latest) to build matrix

---
 .github/workflows/build.yml |  2 +-
 .github/workflows/test.yml  |  2 +-
 Dockerfile                  |  2 +-
 README.md                   |  1 +
 build.sh                    | 13 +++++++++++--
 ddev-install.sh             | 24 +++++++++++++++++++-----
 tests/test.bats             | 25 +++++++++++++++----------
 7 files changed, 49 insertions(+), 20 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1ba68ab..4f6b013 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        version: [ v1.24, v1.23, v1.22 ]
+        version: [ latest, v1.24, v1.23, v1.22 ]
     steps:
       -
         name: Checkout code
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 9bff051..5cab827 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        version: [ v1.24, v1.23, v1.22 ]
+        version: [ latest, v1.24, v1.23, v1.22 ]
     steps:
       -
         name: Checkout code
diff --git a/Dockerfile b/Dockerfile
index eb204c4..4e4a052 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -6,6 +6,6 @@ ARG ddev_version
 ENV DDEV_VERSION=${ddev_version}
 
 COPY ddev-install.sh ddev-install.sh
-RUN ash ddev-install.sh && rm ddev-install.sh
+RUN ash ddev-install.sh
 USER ddev
 RUN mkcert -install
diff --git a/README.md b/README.md
index 22c08d3..79ad7a6 100644
--- a/README.md
+++ b/README.md
@@ -36,6 +36,7 @@ Available options:
 
 | Command               | Tags to be created             |
 |-----------------------|--------------------------------|
+| ./build.sh -v latest  | latest (aka head/nightly)      |
 | ./build.sh -v v1.22   | v1.22, v1.22.x (latest bugfix) |
 | ./build.sh -v v1.22.5 | v1.22.5                        |
 | ./build.sh -v v1.23   | v1.23, v1.23.x (latest bugfix) |
diff --git a/build.sh b/build.sh
index 40231e3..a8df6a1 100755
--- a/build.sh
+++ b/build.sh
@@ -69,13 +69,22 @@ while getopts ":v:hplx" opt; do
     PLATFORM="--platform linux/amd64,linux/arm64"
     ;;
   *)
-    echo "Invalid option: -$OPTARG"
     help
+    echo "Invalid option: -$OPTARG"
     exit 1
     ;;
   esac
 done
 
-loadVersionAndTags
+# Set version and tag for latest (aka nightly)
+if [ "$OPTION_VERSION" = "latest" ]; then
+  DDEV_VERSION="latest"
+  DOCKER_TAGS=("-t $IMAGE_NAME:latest")
+else
+  loadVersionAndTags
+fi
+
+echo $DDEV_VERSION
+echo $DOCKER_TAGS
 
 docker buildx build ${PLATFORM} --progress plain --no-cache --pull . -f Dockerfile ${DOCKER_TAGS[@]} --build-arg ddev_version="$DDEV_VERSION" $PUSH $LOAD
diff --git a/ddev-install.sh b/ddev-install.sh
index b5c555e..ba0e296 100755
--- a/ddev-install.sh
+++ b/ddev-install.sh
@@ -20,15 +20,29 @@ case ${unamearch} in
 ;;
 esac
 
-wget "https://github.com/ddev/ddev/releases/download/${DDEV_VERSION}/ddev_linux-${ARCH}.${DDEV_VERSION}.tar.gz"
-
 # Prepare and install binaries
 mkdir ddev
-tar xfvz "ddev_linux-${ARCH}.${DDEV_VERSION}.tar.gz" --directory ddev
+
+if [ "$DDEV_VERSION" = "latest" ]; then
+  # Download ddev head (nightly)
+  wget "https://nightly.link/ddev/ddev/workflows/master-build/master/all-ddev-executables.zip"
+
+  unzip all-ddev-executables.zip
+  tar xfvz ddev_linux-${ARCH}.* --directory ddev
+  # Extract nightly version from file name
+  LAST_STARTED_VERSION=$(find ddev_linux-${ARCH}* | sed -n "s/.*ddev_linux-${ARCH}\.\(.*\)\.tar\.gz/\1/p")
+else
+  # Download specific ddev version
+  wget "https://github.com/ddev/ddev/releases/download/${DDEV_VERSION}/ddev_linux-${ARCH}.${DDEV_VERSION}.tar.gz"
+
+  tar xfvz "ddev_linux-${ARCH}.${DDEV_VERSION}.tar.gz" --directory ddev
+  LAST_STARTED_VERSION=${DDEV_VERSION}
+fi
+
 mv ddev/ddev /usr/local/bin/
 mv ddev/mkcert /usr/local/bin/
 sudo -i ddev /usr/local/bin/mkcert -install
-rm -Rf ddev "ddev_linux-${ARCH}.${DDEV_VERSION}.tar.gz"
+rm -Rf ddev*
 
 # Ensure required folders exist
 mkdir -p /home/ddev/.ddev/commands/host
@@ -37,7 +51,7 @@ disable_http2: false
 fail_on_hook_fail: false
 instrumentation_opt_in: false
 internet_detection_timeout_ms: 3000
-last_started_version: ${DDEV_VERSION}
+last_started_version: ${LAST_STARTED_VERSION}
 letsencrypt_email: ""
 mkcert_caroot: /home/ddev/.local/share/mkcert
 no_bind_mounts: false
diff --git a/tests/test.bats b/tests/test.bats
index b9a2569..fc66796 100644
--- a/tests/test.bats
+++ b/tests/test.bats
@@ -12,9 +12,14 @@
 
 @test "See ddev version" {
     run docker-run "ddev version -j"
-
     version=$(echo "$output" | tail -n 1 | yq '.raw.["DDEV version"]')
-    regex='^v([0-9]+)\.([0-9]+)\.([0-9]+)$'
+
+    if [ "$DDEV_VERSION" = "latest" ]; then
+      # The HEAD version contains a hash e.g. v1.24.1-4-gbce95e65e
+      regex='^v([0-9]+)\.([0-9]+)\.([0-9]+)-([0-9]+)-([a-z0-9]+)$'
+    else
+      regex='^v([0-9]+)\.([0-9]+)\.([0-9]+)$'
+    fi
 
     [[ $version =~ $regex ]]
     [ "$status" -eq 0 ]
@@ -27,6 +32,14 @@
     [ "$status" -eq 0 ]
 }
 
+
+@test "Run ddev debug dockercheck" {
+    run docker-run "ddev debug dockercheck"
+
+    [[ "$output" == *"Able to run simple container that mounts a volume."* ]]
+    [[ "$output" == *"Able to use internet inside container."* ]]
+    [ "$status" -eq 0 ]
+}
 @test "Create and run a ddev project" {
     local TEST_COMMAND="
         mkdir ~/ddev-test
@@ -45,14 +58,6 @@
     [ "$status" -eq 0 ]
 }
 
-@test "Run ddev debug dockercheck" {
-    run docker-run "ddev debug dockercheck"
-
-    [[ "$output" == *"Able to run simple container that mounts a volume."* ]]
-    [[ "$output" == *"Able to use internet inside container."* ]]
-    [ "$status" -eq 0 ]
-}
-
 # Use "--no-bind-mounts=true" to make "ddev debug test" pass. This is only required in testing environment
 @test "Run ddev debug test" {
     local TEST_COMMAND="