Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externals, Globals & Horizontal Subdomains #71

Closed
wants to merge 14 commits into from
Closed

Externals, Globals & Horizontal Subdomains #71

wants to merge 14 commits into from

Conversation

BenWeber42
Copy link
Contributor

Closes #60

@BenWeber42 BenWeber42 changed the title Externals horizontal domains Externals Jan 18, 2021
@BenWeber42
Copy link
Contributor Author

BenWeber42 commented Jan 18, 2021 •
edited
Loading

Next steps:

  • Review & Merge Include center #66
  • Rebase onto Include center #66
  • Implement globals
  • Implement domains (focused on functionality)
  • Cleanup the changes (this is halfway done)
  • Probably need to add tech-debt/cleanup issues as a follow up

@BenWeber42 BenWeber42 mentioned this pull request Jan 18, 2021
Merged
@BenWeber42 BenWeber42 force-pushed the externals-horizontal-domains branch from 9f39043 to 77a07b7 Compare January 18, 2021 15:42
@BenWeber42 BenWeber42 force-pushed the externals-horizontal-domains branch from 9b5e4a7 to 4b38e24 Compare January 19, 2021 04:36
@BenWeber42
Preliminary implementation of horizontal domains
5a4ad62 
This is a preliminary implementation. It mainly contains the
functionality for horizontal domains. There's still quite a bit of
cleanup left to do.
@BenWeber42 BenWeber42 force-pushed the externals-horizontal-domains branch from 968d16b to 5a4ad62 Compare January 22, 2021 08:31
@BenWeber42 BenWeber42 linked an issue Jan 22, 2021 that may be closed by this pull request
Create read-only global variables #36
Closed
3 tasks
@BenWeber42 BenWeber42 changed the title Externals Externals, Globals & Horizontal Subdomains Jan 29, 2021
This was referenced Jan 29, 2021
Open
Open
@BenWeber42 BenWeber42 linked an issue Jan 29, 2021 that may be closed by this pull request
Cleanup externals, globals & horizontal subdomains #73
Open
@BenWeber42
Copy link
Contributor Author

See #87

@BenWeber42 BenWeber42 closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@BenWeber42