Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncertainties and variances #42

Open
m-wells opened this issue Oct 9, 2020 · 4 comments · May be fixed by #43
Open

Uncertainties and variances #42

m-wells opened this issue Oct 9, 2020 · 4 comments · May be fixed by #43

Comments

@m-wells
Copy link

m-wells commented Oct 9, 2020

I believe there is a typo in

When the uncertainties are Gaussian and their variances $\sigma_{yi}$
which should be

    When the uncertainties are Gaussian and their variances $\sigma_{yi}^2$

I also found this problem to be poorly worded

\begin{problem}\label{prob:chi2}
Re-do the fit of \problemname~\ref{prob:easy} but setting all
$\sigma_{yi}^2=S$, that is, ignoring the uncertainties and replacing
them all with the same value $S$. What uncertainty variance $S$ would
make $\chi^2 = N-2$? Relevant plots are shown in
\figurename~\ref{fig:chi2}. How does it compare to the mean and
median of the uncertainty variances $\allsigmay$?
\end{problem}

The statement

setting all $\sigma_{yi}^2=S$, that is, ignoring the uncertainties and replacing them all with the same value $S$

is not self-consistent.
I believe it should read as

\begin{problem}\label{prob:chi2} 
 Re-do the fit of \problemname~\ref{prob:easy} but setting all 
 $\sigma_{yi}=S$, that is, ignoring the uncertainties and replacing 
 them all with the same value $\sqrt(S)$.  What uncertainty variance $S$ would 
 make $\chi^2 = N-2$?  Relevant plots are shown in 
 \figurename~\ref{fig:chi2}.  How does it compare to the mean and 
 median variance of the uncertainty $\allsigmay$? 
 \end{problem} 
@m-wells m-wells linked a pull request Oct 9, 2020 that will close this issue
@jobovy
Copy link
Collaborator

jobovy commented Oct 9, 2020

I don't think this is correct that we set sigma_y equal to S in this exercise (exercise 11 in the arXiv version). The code that produces these figures is here (we re-numbered the exercises after writing the code) and you can see that we set the data covariance to S x identity matrix as stated in the problem.

@m-wells
Copy link
Author

m-wells commented Oct 9, 2020

@jobovy You are correct and I was in mid edit correction as I was looking my work. I still think the wording is a bit unclear though.

@m-wells
Copy link
Author

m-wells commented Oct 9, 2020

@jobovy I have edited my initial comment.

@m-wells
Copy link
Author

m-wells commented Oct 9, 2020

My confusion essentially boils down to two typos which I have fixed in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants