Let reviewers rate PRs, and coder rate reviews

[davearonson]

As a reviewer/coder,
I want to have my reviews/PRs rated,
so I can show off how awesum [sic] I am!!!1!!1!!one!!

I don't quite feel up to writing the tests for this right now. Later. This is a placeholder.

[cupakromer]

Do you plan on this being a star type rating (maybe allow half stars?). Or more written feedback?

[davearonson]

I didn't want to nail it down to a specific implementation (stars vs. a percentage, letter-grade, or whatever) quite yet. Yes, I was thinking most likely it would be stars, up to five, with halves allowed. (Not sure if zero should be allowed, but again, that's getting deeper into the weeds than I should at this time.)

The general idea was some kind of numerical (or numericalizable -- if that wasn't a word before, it is now!) rating that could be very concisely displayed, understood at a glance, and easily filtered on. Written feedback could still take place as the usual code comments in the PR itself, the issue it's about (assuming that's on Github or some other place both people have access to), or by email.

However, now that you raise the possibility, written feedback certainly could be added to PRR, as more detailed overall feedback from Person X about Person Y's performance in Role Z. Maybe even specific to a given PR, attaching the numeric rating, and explaining it. Maybe even both. If PRR storing written feedback is something you'd like to see, go ahead and write up a ticket for it. Given the current stack of tickets, though, I think it would be rather low priority.

[davearonson]

Oh, another thing I was thinking: instead of, or perhaps in addition to, an overall transaction rating, it could be broken into categories. For instance, a coder could get rated on the code's clarity, robustness, efficiency, etc., and the reviewer could get rated on clarity, motivating manner, helpfulness (e.g., not just "don't do that" but "it's better to do this instead"), etc. The reviewer rating categories will probably draw heavily on the Toastmasters guidelines for a speech evaluation. :-)