Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs still listed 3 years after closing and after repo archiving #40

Open
Pr0methean opened this issue Aug 22, 2019 · 4 comments
Open

PRs still listed 3 years after closing and after repo archiving #40

Pr0methean opened this issue Aug 22, 2019 · 4 comments

Comments

@Pr0methean
Copy link

Pr0methean commented Aug 22, 2019

Visiting pullrequestroulette.com right now, I found that only 2 of the first 10 PRs on the list were open and in reachable, non-archived repos. The closed ones had been closed for at least 20 months! Shouldn't the app periodically check for this?

alvarotrigo/fullPage.js#612 (closed 2016-04-29)
freeCodeCamp/camper-gitter-bot#89 (merged 2016-05-07, repo now archived)
freeCodeCamp/camper-gitter-bot#83 (closed 2016-10-16, repo now archived)
petdance/html-tidy#19 (closed 2017-05-26, repo now archived)
mstevens/Proc--InvokeEditor#3 (open at the time of reporting)
tobyink/p5-type-tiny#21 (merged 2017-02-08)
erichoracek/MSDynamicsDrawerViewController#21 (open)
https://github.com/saurabhlambe/hello-world/pull/3 (repo 404)
dolmen-perl5/Git-Sub#4 (closed 2016-10-18)
mindmup/bootstrap-wysiwyg#50 (open, but repo now archived)

@koppor
Copy link

koppor commented Oct 6, 2019

@davearonson This gets important, because this repository is listed by digital ocean at https://hacktoberfest.digitalocean.com/details in the context of #hacktoberfest.

grafik

@davearonson
Copy link
Owner

Having it check for PR status, whether on some kind of schedule (which of course requires knowing what kind of system it's deployed, which for now is Heroku) or on use (maybe kicked off as a background job after each use?), and removing closed or otherwise dead PRs, would be a great PR for someone to submit.... :-)

@davearonson
Copy link
Owner

@koppor Oh wow, it hit the big time... and apparently in a broken state. Dang. Sorry 'bout that. I'll try to get some time Real Soon Now to delve into why it's broken, probably assorted upgrades that Heroku has forced upon it.

@remram44
Copy link

remram44 commented Oct 3, 2021

Found this through the Hacktoberfest 2021 website, but I see a lot of closed/merged/archived PRs 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants