From 9c27c9883250f1699384acabc85e2deb045884ab Mon Sep 17 00:00:00 2001 From: Gabriel Stefanini Vicente Date: Tue, 13 Feb 2024 09:23:01 -0500 Subject: [PATCH] Remove scaffolding (#19) --- .env.example | 1 - .github/ISSUE_TEMPLATE/bug_report.md | 59 ++++----- .pre-commit-config.yaml | 44 +++++++ CONTRIBUTING.md | 45 ------- README.md | 14 ++- _static/custom.css | 2 +- docs/CODE_OF_CONDUCT.md | 13 +- docs/_config.yml | 7 +- docs/_toc.yml | 6 +- docs/business-trends.md | 7 +- ..._datasets_and_data_products.md => data.md} | 4 +- docs/gallery.md | 114 ------------------ ...goods.md => introduction-to-data-goods.md} | 0 docs/requirements.txt | 2 +- notebooks/nighttime-lights/README.md | 2 - src/datalab/__init__.py | 1 - src/datalab/indicators.py | 84 ------------- 17 files changed, 104 insertions(+), 301 deletions(-) delete mode 100644 .env.example create mode 100644 .pre-commit-config.yaml delete mode 100644 CONTRIBUTING.md rename docs/{foundational_datasets_and_data_products.md => data.md} (98%) delete mode 100644 docs/gallery.md rename docs/{introduction_to_data_goods.md => introduction-to-data-goods.md} (100%) delete mode 100644 src/datalab/__init__.py delete mode 100644 src/datalab/indicators.py diff --git a/.env.example b/.env.example deleted file mode 100644 index 5982ee0..0000000 --- a/.env.example +++ /dev/null @@ -1 +0,0 @@ -NASA_API_KEY = \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index dd84ea7..eab0fd0 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,38 +1,43 @@ --- -name: Bug report -about: Create a report to help us improve +name: Bug Report +about: Use to report a bug title: '' -labels: '' +labels: bug assignees: '' - --- -**Describe the bug** -A clear and concise description of what the bug is. +## Bug Report + +### Description + +Provide a brief overview of the bug encountered. Describe the behavior observed when the bug occurs and explain the behavior expected when the bug is not present. + +### Reproducibility + +- [ ] The bug is reproducible. +- [ ] The bug is intermittent. +- [ ] The bug occurs only under specific conditions. + +#### Steps to Reproduce + +1. List the steps to reproduce the bug. +2. Be as detailed as possible to help with replication. + +#### Screenshots / Error Messages (if applicable) + +Insert any relevant screenshots or error messages related to the bug. -**To Reproduce** -Steps to reproduce the behavior: -1. Go to '...' -2. Click on '....' -3. Scroll down to '....' -4. See error +#### Environment -**Expected behavior** -A clear and concise description of what you expected to happen. +- **Operating System**: [e.g., Windows 10, macOS, Linux] +- **Browser (if applicable)**: [e.g., Google Chrome, Firefox, Safari] +- **Application Version/Commit**: [e.g., v1.2.3, Git commit hash] +- **Additional Environment Details**: [e.g., hardware specifications, network conditions] -**Screenshots** -If applicable, add screenshots to help explain your problem. +### Additional Context -**Desktop (please complete the following information):** - - OS: [e.g. iOS] - - Browser [e.g. chrome, safari] - - Version [e.g. 22] +Provide any additional context or information about the bug. -**Smartphone (please complete the following information):** - - Device: [e.g. iPhone6] - - OS: [e.g. iOS8.1] - - Browser [e.g. stock browser, safari] - - Version [e.g. 22] +### Possible Fix -**Additional context** -Add any other context about the problem here. +If you have suggestions for a fix, please describe them here. diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 0000000..854e301 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,44 @@ +# See https://pre-commit.com for more information +# See https://pre-commit.com/hooks.html for more hooks +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v3.2.0 + hooks: + - id: trailing-whitespace + - id: end-of-file-fixer + - id: check-yaml + - id: check-added-large-files + - id: check-ast + - id: check-json + - id: detect-aws-credentials + args: [--allow-missing-credentials] + - id: detect-private-key + - repo: https://github.com/igorshubovych/markdownlint-cli + rev: v0.39.0 + hooks: + - id: markdownlint + name: Markdownlint + files: \.(md|mdown|markdown)$ + args: [ + "--disable=MD013", # line-length + "--disable=MD033", # no-inline-html + ] + - repo: https://github.com/codespell-project/codespell + rev: v2.2.4 + hooks: + - id: codespell + name: codespell + description: Checks for common misspellings in text files + exclude: > + (?x)^( + .*\.json| + )$ + args: ["-L", "gost,"] # ignore words + - repo: https://github.com/astral-sh/ruff-pre-commit + rev: v0.2.1 + hooks: + - id: ruff + types_or: [python, pyi, jupyter] + args: [--fix] + - id: ruff-format + types_or: [python, pyi, jupyter] diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md deleted file mode 100644 index a9448b6..0000000 --- a/CONTRIBUTING.md +++ /dev/null @@ -1,45 +0,0 @@ -# CONTRIBUTING - -Thank you for considering contributing! We appreciate your interest in helping us improve our project. By contributing, you agree to abide by our [Code of Conduct](docs/CODE_OF_CONDUCT.md). - -Please take a moment to review this document for important information on how to contribute effectively. - -## How Can I Contribute? - -There are several ways you can contribute to this project: - -- **Bug Reports:** If you encounter a bug or unexpected behavior, please open an issue on our GitHub issue tracker. Be sure to include as much detail as possible to help us identify and fix the problem. - -- **Feature Requests**: If you have an idea for a new feature or enhancement, please open an issue on our GitHub issue tracker and label it as a "feature request." Describe the feature and its use case in detail. - -- **Pull Requests:** If you'd like to contribute code or documentation changes, we encourage you to submit a pull request (PR). Please follow the guidelines outlined in the [Contributing Code](CONTRIBUTING.md) section below. - -- **Documentation:** If you find any errors or have suggestions for improving our documentation, you can submit changes directly through a pull request. - -- **Community Engagement:** Help answer questions and engage with other users and contributors on our GitHub Discussions (if applicable). - -## Contributing Code - -If you're contributing code, please follow these guidelines: - -1. **Fork the Repository**: Click the "Fork" button on the top-right corner of this repository on GitHub. This will create a copy of the project in your GitHub account. - -2. **Create a Branch:** Create a new branch for your feature or bug fix. Use a clear and descriptive name for your branch, like `feature/my-new-feature` or `bugfix/issue-123`. - -3. **Make Changes:** Make your code changes and ensure they adhere to our coding standards. - -4. **Test:** Ensure that your changes do not break existing functionality and add tests for new features or bug fixes. - -5. **Commit and Push:** Commit your changes with a clear and concise commit message. Reference any related issues or pull requests in your commit message. Push your branch to your forked repository on GitHub. - -6. **Create a Pull Request:** Open a pull request against the main branch of this repository. Provide a clear description of your changes and reference any relevant issues. Your PR will be reviewed by maintainers. - -7. **Review and Iterate:** Expect feedback and be prepared to make additional changes if necessary. We may request changes, and once everything looks good, your PR will be merged. - -## Code of Conduct - -Please note that we have a [Code of Conduct](docs/CODE_OF_CONDUCT) in place. We expect all contributors to adhere to it, both in interactions within this project and in interactions with other project members. - -## Licensing - -By contributing to this project, you agree that your contributions will be licensed under the project's [LICENSE](LICENSE). diff --git a/README.md b/README.md index 9a3861e..9add149 100644 --- a/README.md +++ b/README.md @@ -2,10 +2,20 @@ The MENA MTI team is preparing the Egypt Country Economic Memorandum (CEM) and other reports that monitor trends in the Egyptian economy. This repository includes an exploration of alternative data sources that could support analysis of Egypt's economic growth and demographics. -## Data Availability Statement +## Contributing + +We welcome contributions to improve this documentation. If you find errors, have suggestions, or want to add new content, please follow our [contribution guidelines](docs/CONTRIBUTING.md). + +### Feedback and Issues + +If you have any feedback, encounter issues, or want to suggest improvements, please [open an issue](https://github.com/datapartnership/gaza-israel-conflict-impact-analysis/issues/new/choosem). + +## Data + +### Data Availability Statement Restrictions may apply to the data that support the findings of this study. Data received from the private sector through the Development Data Partnership are subject to the terms and conditions of the data license agreement and the "Official Use Only" data classification. These data are available upon request through the [Development Data Partnership](https://datapartnership.org). Licensing and access information for all other datasets are included in the documentation. ## License -The repository is licensed under the [Mozilla Public License](https://www.mozilla.org/en-US/MPL/). +This projects is licensed under the [**Mozilla Public License**](https://opensource.org/license/mpl-2-0/) - see the [LICENSE](LICENSE) file for details. diff --git a/_static/custom.css b/_static/custom.css index 7cf8936..4d2d7f3 100644 --- a/_static/custom.css +++ b/_static/custom.css @@ -45,4 +45,4 @@ a.current.reference.internal { #pst-back-to-top { background-color: #3eacad; -} \ No newline at end of file +} diff --git a/docs/CODE_OF_CONDUCT.md b/docs/CODE_OF_CONDUCT.md index 746991f..9d623a1 100644 --- a/docs/CODE_OF_CONDUCT.md +++ b/docs/CODE_OF_CONDUCT.md @@ -114,15 +114,6 @@ the community. ## Attribution -This Code of Conduct is adapted from the [Contributor Covenant][homepage], -version 2.0, available at -https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. - -Community Impact Guidelines were inspired by [Mozilla's code of conduct +This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org), +version 2.0. Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity). - -[homepage]: https://www.contributor-covenant.org - -For answers to common questions about this code of conduct, see the FAQ at -https://www.contributor-covenant.org/faq. Translations are available at -https://www.contributor-covenant.org/translations. diff --git a/docs/_config.yml b/docs/_config.yml index 5c5b9b3..e70d8ca 100644 --- a/docs/_config.yml +++ b/docs/_config.yml @@ -2,7 +2,7 @@ title: author: Development Data Group logo: docs/images/logo.png -only_build_toc_files: true +only_build_toc_files: false repository: url: https://github.com/datapartnership/egypt-economic-monitor @@ -19,7 +19,10 @@ html: baseurl: https://datapartnership.github.io/egypt-economic-monitor extra_footer: |
- All maps are for illustrative purposes and do not imply the expression of any opinion on the part of the World Bank, concerning the legal status of any country or territory or concerning the delimitation of frontiers or boundaries. All content (unless otherwise specified) is subject to the Mozilla Public License. + Country borders or names do not necessarily reflect the World Bank Group’s official position. All maps are for illustrative purposes and do not imply the expression of any opinion on the part of the World Bank, concerning the legal status of any country or territory or concerning the delimitation of frontiers or boundaries +
+
+ All content (unless otherwise specified) is subject to the Mozilla Public License.
favicon: docs/images/favicon.ico diff --git a/docs/_toc.yml b/docs/_toc.yml index d26043d..cae9965 100644 --- a/docs/_toc.yml +++ b/docs/_toc.yml @@ -4,10 +4,8 @@ root: README parts: - caption: Introduction to Data Goods chapters: - - file: docs/introduction_to_data_goods - - caption: Understanding Egypt's Economy through Alternative Data - chapters: - - file: docs/foundational_datasets_and_data_products + - file: docs/introduction-to-data-goods + - file: docs/data - caption: Data Products chapters: - file: notebooks/activity/business-activity-trends.ipynb diff --git a/docs/business-trends.md b/docs/business-trends.md index 53cf3a2..3eb44e8 100644 --- a/docs/business-trends.md +++ b/docs/business-trends.md @@ -1,10 +1,9 @@ # Analysing Business Activity Trends in Egypt -[Business Activity Trends](https://dataforgood.facebook.com/dfg/tools/business-activity-trends#methodology) are a crisis-triggered dataset released by Meta. The dataset is relesed at a national level. [GADM shpefiles](https://gadm.org/) are slightly different from the official shapefiles used in this project from [HdX, UNOCHA](https://data.humdata.org/dataset/cod-ab-tur). COVID-19 triggered dataset is used in this analysis. +[Business Activity Trends](https://dataforgood.facebook.com/dfg/tools/business-activity-trends#methodology) are a crisis-triggered dataset released by Meta. The dataset is relesed at a national level. [GADM shpefiles](https://gadm.org/) are slightly different from the official shapefiles used in this project from [HdX, UNOCHA](https://data.humdata.org/dataset/cod-ab-tur). COVID-19 triggered dataset is used in this analysis. -Business Activity Trends During Crisis uses data about posting activity on Facebook to measure how local businesses are affected by and recover from crisis events. Given the broad presence of small businesses on the Facebook platform, this dataset aims to provide timely estimates of global business activity without the common limitations of traditional data collection methods, such as scale, speed and nonstandardization. This is a crisis-triggered dataset i.e., it has been created by Meta to support humanitarian relief for post COVID in Egypt. Details about this dataset can be found on [Meta's Data For Good page](https://dataforgood.facebook.com/dfg/tools/business-activity-trends). +Business Activity Trends During Crisis uses data about posting activity on Facebook to measure how local businesses are affected by and recover from crisis events. Given the broad presence of small businesses on the Facebook platform, this dataset aims to provide timely estimates of global business activity without the common limitations of traditional data collection methods, such as scale, speed and nonstandardization. This is a crisis-triggered dataset i.e., it has been created by Meta to support humanitarian relief for post COVID in Egypt. Details about this dataset can be found on [Meta's Data For Good page](https://dataforgood.facebook.com/dfg/tools/business-activity-trends). -The Business Activity Trends dataset was provided by [Meta](https://dataforgood.facebook.com/dfg/tools/business-activity-trends) through the proposal [Egypt Country Economic Monitor](https://portal.datapartnership.org/readableproposal/427) of the [Development Data Partnership](https://datapartnership.org). The data consisted of daily business activity quantile information at a GADM 2 level broken down by business vertical. Each cell (row) of the dataset contains data on the daily activity within a polygon-vertical combination. +The Business Activity Trends dataset was provided by [Meta](https://dataforgood.facebook.com/dfg/tools/business-activity-trends) through the proposal [Egypt Country Economic Monitor](https://portal.datapartnership.org/readableproposal/427) of the [Development Data Partnership](https://datapartnership.org). The data consisted of daily business activity quantile information at a GADM 2 level broken down by business vertical. Each cell (row) of the dataset contains data on the daily activity within a polygon-vertical combination. **The COVID-19 triggered Business Activity Trends dataset contains daily data from March 1, 2020 to Nov 29, 2022 at the national level. Activity quantile is used to measure the business activity trends in this dataset.** - diff --git a/docs/foundational_datasets_and_data_products.md b/docs/data.md similarity index 98% rename from docs/foundational_datasets_and_data_products.md rename to docs/data.md index c604cdc..cb45db7 100644 --- a/docs/foundational_datasets_and_data_products.md +++ b/docs/data.md @@ -1,6 +1,6 @@ -# Foundational Datasets, Data Products, & Sample Indicators +# Datasets, Data Products, & Sample Indicators -## Foundational Datasets +## Datasets **Foundational Datasets** refer to **all** datasets used in the analytics prepared for a project. The Foundational Datasets table includes a description of the data and their update frequency, as well as access links and contact information for questions about use and access. Users should not require any datasets not included in this table to complete the analytical work for the Data Good. diff --git a/docs/gallery.md b/docs/gallery.md deleted file mode 100644 index a54da18..0000000 --- a/docs/gallery.md +++ /dev/null @@ -1,114 +0,0 @@ -## Projects using the template - -> A curated list of projects/repositories using the template. - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [Syria Economic Monitor](https://datapartnership.github.io/syria-economic-monitor) -Using Alternative Data to Understand Changing Trends in Trade and Economic Activity in Syria -::: - -:::{grid-item-card} [Türkiye Earthquake Impact](https://datapartnership.github.io/turkiye-earthquake-impact) -Using Alternative Data to Understand Economic Impacts of the 2023 Turkey–Syria Earthquake -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [Lebanon Economic Monitor](https://datapartnership.github.io/lebanon-economic-monitor) -Understanding Lebanon’s Economy through Alternative Data -::: - -:::{grid-item-card} [Mocorro Earthquake Impact](https://datapartnership.github.io/morocco-earthquake-impact) -Using Alternative Data to Understand Economic Impacts of the 2023 Morocco earthquake. -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [Myanmar Economic Monitor](https://datapartnership.github.io/myanmar-economic-monitor) -Understanding Myanmar's Economy through Alternative Data -::: - -:::{grid-item-card} [Pacific Observatory](https://worldbank.github.io/pacific-observatory) -The Pacific Observatory is the World Bank analytical program to explore and develop new information sources to mitigate the impact of data gaps in official statistics for Papua New Guinea (PNG) and the Pacific Island Countries (PICs). - -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [REaLTabFormer](https://worldbank.github.io/REaLTabFormer) -A suite of auto-regressive and Seq2Seq (sequence-to-sequence) transformer models for tabular and relational synthetic data generation. -::: -:::{grid-item-card} [iQual](https://worldbank.github.io/iQmual) -iQual is a package that leverages natural language processing to scale up interpretative qualitative analysis. It also provides methods to assess the bias, interpretability and efficiency of the machine-enhanced codes. iQual has been applied to analyse interviews on parents' aspirations for their children in Cox's Bazaar, Bangladesh. -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [GEE Zonal](https://worldbank.github.io/GEE_Zonal/) -This python package provides a wrapper function to request temporal and zonal statistics from Google Earth Engine (GEE) datasets. -::: - -:::{grid-item-card} [Geospatial Operations Support Team (GOST)](https://worldbank.github.io/GOST) -We document important resources, methods, and sources in real time via this live wiki. This repository is the evolving, growing workspace where GOST stores libraries and scripts for operationalizing the many initatives urrenctly on going in the geospatial realm within the World Bank Group. -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [DECAT_Space2Stats](https://worldbank.github.io/DECAT_Space2Stats) -Consistent, comparable, authoritative data describing sub-national variation is a constant point of complication for World Bank teams, our development partners, and client countries when assessing and investigating economic issues and national policy. This project will focus on creating and disseminating such data through aggregation of geospatial information at standard administrative divisions, and through the attribution of household survey data with foundational geospatial variables. -::: - -:::{grid-item-card} [ZAF_Econ_Diversification](https://worldbank.github.io/ZAF_Econ_Diversification) -Mapping and quantifying opportunities for economic diversification in Mpumalanga in South Africa -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [GFF Health Equity](https://worldbank.github.io/health-equity-diagnostics) -This repository contains scripts developed by GOST to map health facilities and understand differences in population access in support of the GFF Country Equity Diagnostic and other projects. -::: - -:::{grid-item-card} [Heatwaves Data Collaborative](https://datapartnership.org/heatwaves/PH) -The Heatwaves Data Collaborative enables teams across sectors and -organizations to simultaneously focus on their areas of expertise, while -collaborating through use of common frameworks and datasets, standards for -production and review of reusable methods, and through regular check-ins to -ensure the different work streams are aligned and build upon each other. -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [Geospatial Analysis - MENA Poverty and Equity Group](https://worldbank.github.io/mena-pov) -The Geospatial Analysis repository aims to centrally maintain cleaning and analysis of data that leverage geospatial data conducted by the Poverty and Equity Group in the MENA region. -::: - -:::{grid-item-card} [Health Planning in the Philippines](https://datapartnership.org/health-planning-in-philippines) -The team conducted geospatial analysis to advise on key questions that could inform a more integrated health care system, starting with three LGUs (Bohol, Baguio City, and Maguindanao). -::: -:::: - -::::{grid} -:gutter: 2 - -:::{grid-item-card} [Understanding societal responses to policies undertaken during emergencies: Lessons from COVID-19’s Second Wave in Maharashtra](https://datapartnership.github.io/covid-19-maharashtra) -Understanding societal responses to policies undertaken during emergencies: Lessons from COVID-19's Second Wave in Maharashtra -::: - -:::{grid-item-card} [Understanding the vulnerability of New Delhi to Heatwaves](https://datapartnership.org/vulnerability-to-heatwaves-in-india) -Part of Understanding the vulnerability of New Delhi to Heatwaves, this repository holds a collection of (experimental) Jupyter notebooks exploring data available through the Development Data Partnership. -::: -:::: diff --git a/docs/introduction_to_data_goods.md b/docs/introduction-to-data-goods.md similarity index 100% rename from docs/introduction_to_data_goods.md rename to docs/introduction-to-data-goods.md diff --git a/docs/requirements.txt b/docs/requirements.txt index 873d7b8..51aa100 100644 --- a/docs/requirements.txt +++ b/docs/requirements.txt @@ -1,2 +1,2 @@ docutils==0.17.1 -jupyter-book==1.0.0 \ No newline at end of file +jupyter-book==1.0.0 diff --git a/notebooks/nighttime-lights/README.md b/notebooks/nighttime-lights/README.md index 3aa5b24..7e38d89 100644 --- a/notebooks/nighttime-lights/README.md +++ b/notebooks/nighttime-lights/README.md @@ -42,5 +42,3 @@ To address these assumptions and limitations, it is crucial to complement nightt :filter: docname in docnames :style: plain ``` - - diff --git a/src/datalab/__init__.py b/src/datalab/__init__.py deleted file mode 100644 index 3dc1f76..0000000 --- a/src/datalab/__init__.py +++ /dev/null @@ -1 +0,0 @@ -__version__ = "0.1.0" diff --git a/src/datalab/indicators.py b/src/datalab/indicators.py deleted file mode 100644 index 4cf79a2..0000000 --- a/src/datalab/indicators.py +++ /dev/null @@ -1,84 +0,0 @@ -import pandas -import pycountry -import requests - - -class WorldBankIndicatorsAPI: - - URL = "https://api.worldbank.org/v2/country" - - def _get_country_code(self, country): - """ - Using `pycountry`, return the ISO 3166-1 alpha-3 country code for corresponding query term. - - See also: - https://github.com/flyingcircusio/pycountry - - Parameters - ---------- - country : str - - Returns - ------- - str - ISO 3166-1 alpha-3 country code for corresponding query term. - - Raises - ------ - LookupError - If the query term is not a valid country. - """ - return pycountry.countries.search_fuzzy(country)[0].alpha_3 - - def _get(self, indicator, country: str = "all", params: dict = {}): - """ - Retrieve a response, valid JSON response or error, from the World Bank Indicators API. - - See also: - https://datahelpdesk.worldbank.org/knowledgebase/articles/889392-about-the-indicators-api-documentation - - Parameters - ---------- - indicator : str - country : str, optional - params : dict, optional - - Returns - ------- - requests.models.Response - Return JSON response from the World Bank Indicators API. - """ - url = f"{self.URL}/{country}/indicator/{indicator}" - - return requests.get(url, params) - - def query(self, indicator, country: list = "all", params: dict = {}): - """ - Retrieve a response, valid JSON response or error, from the World Bank Indicators API. - - See also: - https://datahelpdesk.worldbank.org/knowledgebase/articles/889392-about-the-indicators-api-documentation - - Parameters - ---------- - indicator : str - World Bank API Indicator. - country : list, optional - List of countries. The country name is converted to ISO 3166-1 alpha-3 country code. - params : dict, optional - World Bank API Indicator Query Strings. - - Returns - ------- - pandas.core.frame.DataFrame - Return a Pandas DataFrame obtained with response data from World Bank Indicators API. - """ - if isinstance(country, list): - country = ";".join([self._get_country_code(c) for c in country]) - - params.update({"format": "json", "per_page": 1000}) - - response = self._get(indicator, country, params) - data = response.json()[-1] - - return pandas.json_normalize(data)