<xs:choice maxOccurs="unbounded"> does not produce array type

[marpetr]

Example input:

	<xs:complexType name="Fruits">
		<xs:choice maxOccurs="unbounded">
			<xs:element name="apple" type="js:Apple"/>
			<xs:element name="orange" type="js:Orange"/>
		</xs:choice>
	</xs:complexType>

Expected output: fruits: struct<apple: array<struct<...>>, orange: array<struct<...>>>

Actual output: fruits: struct<apple: struct<...>, orange: struct<...>>

Proposed fix:

spark-xml/src/main/scala/com/databricks/spark/xml/util/XSDToSchema.scala

Line 227 in ddd1ef5

if (element.getMaxOccurs == 1) {

-               if (element.getMaxOccurs == 1) {
+               if (element.getMaxOccurs == 1 && choice.getMaxOccurs == 1) {

[srowen]

I think it would be fine to support this. I think the change is somewhat different though.

If an xs:element within the xs:choice has maxOccurs > 1, then that choice is an array type. That much works now.

If xs:choice has maxOccurs > 1, then the result isn't a struct, but an array of struct.
The resulting Seq of StructField would have to be wrapped up in another ArrayType in this case to express this, I think.

If you can try that and it works would you open a pull request to test?

[ranadheerg]

@marpetr @srowen can I take over this issue ? I would like to work on this if possible ?

[srowen]

Sure, you can open a pull request if you like