Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Qustion about regular_train_op ----main.py line 66 #2

Open
DanyaXu opened this issue Jun 19, 2020 · 2 comments
Open

A Qustion about regular_train_op ----main.py line 66 #2

DanyaXu opened this issue Jun 19, 2020 · 2 comments

Comments

@DanyaXu
Copy link

DanyaXu commented Jun 19, 2020

After reading your article, I was deeply inspired, but there was a problem when reading the code. During training, the optimizer ‘dann_trian_op’ was used, but the optimizer ‘regular_train_op’ was not used. Why?

@daoyuan98
Copy link
Owner

Hi, the regular_train_op in line66 is just an op for testing when I was writing the code which optimizes only one classification loss and no domain adversarial loss is optimized. While dann_train_op in line67 optimizes the sum of both domain adversarial loss and regular classification loss, which is actually the loss proposed in the paper.

@DanyaXu
Copy link
Author

DanyaXu commented Jun 22, 2020

Hi, the regular_train_op in line66 is just an op for testing when I was writing the code which optimizes only one classification loss and no domain adversarial loss is optimized. While dann_train_op in line67 optimizes the sum of both domain adversarial loss and regular classification loss, which is actually the loss proposed in the paper.

Okay, thank you very much for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants