Add extra connection host with default value as host #489
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcarvalho could you please take a look? |
|
or shall I ping @cyrilgdn ? |
|
@sichenzhao Seems good to me but even with the associated issue, I'm not sure I got the point of this? Could you just explain a bit more the use case please? |
|
To explain, for people use tailscale for example, we will have different VPN hostname for postgresSQL connection. That's a different url than url AWS can take for AWS API related calls. Thus, people would benefit from this PR which gives an option to differ these two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#317
Add a different connection_host parameter, so that we can use one hostname to get CSP database permissions, and use another hostname when do psql connect.