Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: optional "minimal" ingestion mode #22

Closed
patrislav opened this issue Feb 4, 2021 · 0 comments · Fixed by #23
Closed

aws: optional "minimal" ingestion mode #22

patrislav opened this issue Feb 4, 2021 · 0 comments · Fixed by #23
Assignees
Labels
enhancement New feature or request

Comments

@patrislav
Copy link
Contributor

Abstract

One of the ways we can improve AWS ingestion time (#13) is to support a "minimal" mode. In this mode, only a subset of all the data would be ingested, correlating to the resources we support. This will let library users save time and space by ingesting only around 10% (in the case of EC2) of the pricing file.

Implementation details

This can be done by having a new AWS ingestion option, e.g. WithIngestionFilter, that would accept a filtering function. The function would be called for each pricing record, marking the items that should (and shouldn't) be ingested. Terracost might then define two such functions out-of-the-box: a DefaultFilter that ingests everything and a MinimalFilter that only ingests records necessary for the library to work.

The "minimal" mode shouldn't be the default, as it will require re-ingestion each time new resources or attributes of already existing resources become supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant