Peg the UI version to the server version #8948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only reason to display separate UI and server version (IMO) is that sometimes they can diverge due to deployment issues, and the information can help with diagnostics. So it seems much more useful to use the same version numbering as for the server, since: * This makes it much easier to see whether a divergence exists. * We can automate updates to it, eliminating annoying busywork for developers. * We don't need to show multiple versions for different UI components, simplifying the code and the UI.
SpecLad
force-pushed
the
rm-ui-versions
branch
from
44b700b to
121a013
Compare
|
SpecLad
requested review from
bsekachev,
azhavoro and
nmanovic
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8948 +/- ##
========================================
Coverage 73.86% 73.87%
========================================
Files 416 416
Lines 44413 44410 -3
Branches 3993 3993
========================================
+ Hits 32804 32806 +2
+ Misses 11609 11604 -5
|
bsekachev
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The only reason to display separate UI and server version (IMO) is that sometimes they can diverge due to deployment issues, and the information can help with diagnostics. So it seems much more useful to use the same version numbering as for the server, since:
This makes it much easier to see whether a divergence exists.
We can automate updates to it, eliminating annoying busywork for developers.
We don't need to show multiple versions for different UI components, simplifying the code and the UI.
How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.