Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio upload handler #7113

Closed
wants to merge 68 commits into from
Closed

Conversation

kushalpoddar
Copy link

@kushalpoddar kushalpoddar commented Nov 8, 2023

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Introduced functionality for exporting and importing datasets in YOLO format as ZIP files.
    • Enhanced audio data export capabilities including support for various audio-related attributes and formats.
    • Added new audio annotation features in the application models and database schema.
    • Updated email settings to disable mandatory email verification.
  • Bug Fixes

    • Corrected a file path typo in source path configuration.
  • Documentation

    • Updated environment variables in .vscode/launch.json by removing specific DJANGO log server settings.
  • Refactor

    • Modified various functions to support new audio processing and export features.
  • Chores

    • Added new dependencies to support audio processing (soundfile and pydub).
  • Tests

    • No specific changes mentioned for tests.
  • Style

    • No specific changes mentioned for style adjustments.
  • Revert

    • No specific changes mentioned for reverts.

@nmanovic
Copy link
Contributor

@kushalpoddar , thank you for the PR! Could you please add CHANGELOG? Could you please add instructions and some information about how to use the server with Audino UI?

@kushalpoddar
Copy link
Author

Hi @nmanovic please checkout this branch and readme for the frontend. For no we have just allowed a wav audio file to be uploaded and played. It the code seems fine, we can build more over it with your help. As requested this is a basic prototype

https://github.com/midas-research/audino-frontend/tree/feat/cvat

@@ -12,3 +12,4 @@
# https://github.com/moggers87/django-sendfile2
SENDFILE_BACKEND = 'django_sendfile.backends.nginx'
SENDFILE_URL = '/'
CORS_ALLOW_ALL_ORIGINS = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for your information: https://github.com/adamchainz/django-cors-headers/blob/6f3fe99724bf42e57b062c8959792ca94c669ab0/README.rst#cors_allow_all_origins-bool

Setting this to True can be dangerous, as it allows any website to make cross-origin requests to yours. Generally you'll want to restrict the list of allowed origins with CORS_ALLOWED_ORIGINS or CORS_ALLOWED_ORIGIN_REGEXES.

It is a bad security practice. CVAT repo doesn't need the change, you don't need as well. It is better to list some specific origins. For the development purpose, it is better to run your own CVAT instance and specify additional settings.

@azhavoro , FYI.

@bsekachev bsekachev closed this Mar 15, 2024
@bsekachev bsekachev reopened this Mar 15, 2024
@KTXKIKI
Copy link

KTXKIKI commented Jun 9, 2024

so What progress has been made?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8 Security Hotspots
30.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@bsekachev
Copy link
Member

Hello,
As nobody contributes this pull request, I will close it.

@bsekachev bsekachev closed this Jan 22, 2025
@nmanovic
Copy link
Contributor

@midas-ai , feel free to reopen after you sync changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants