-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio upload handler #7113
Audio upload handler #7113
Conversation
@kushalpoddar , thank you for the PR! Could you please add CHANGELOG? Could you please add instructions and some information about how to use the server with Audino UI? |
Hi @nmanovic please checkout this branch and readme for the frontend. For no we have just allowed a wav audio file to be uploaded and played. It the code seems fine, we can build more over it with your help. As requested this is a basic prototype https://github.com/midas-research/audino-frontend/tree/feat/cvat |
@@ -12,3 +12,4 @@ | |||
# https://github.com/moggers87/django-sendfile2 | |||
SENDFILE_BACKEND = 'django_sendfile.backends.nginx' | |||
SENDFILE_URL = '/' | |||
CORS_ALLOW_ALL_ORIGINS = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for your information: https://github.com/adamchainz/django-cors-headers/blob/6f3fe99724bf42e57b062c8959792ca94c669ab0/README.rst#cors_allow_all_origins-bool
Setting this to True can be dangerous, as it allows any website to make cross-origin requests to yours. Generally you'll want to restrict the list of allowed origins with CORS_ALLOWED_ORIGINS or CORS_ALLOWED_ORIGIN_REGEXES.
It is a bad security practice. CVAT repo doesn't need the change, you don't need as well. It is better to list some specific origins. For the development purpose, it is better to run your own CVAT instance and specify additional settings.
@azhavoro , FYI.
…into feat/audino-v2
Large size, email auto annotation, dynamic lang type
start end in download csv, mp3 format, typo error
so What progress has been made? |
… into feat/audino-v2
Feat: Ground truth logic implemented
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Hello, |
@midas-ai , feel free to reopen after you sync changes |
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
.vscode/launch.json
by removing specific DJANGO log server settings.Refactor
Chores
soundfile
andpydub
).Tests
Style
Revert