Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Track and report compatibility with upstream 'golden' implementation #111

Closed
bbros-dev opened this issue Mar 4, 2021 · 1 comment

Comments

@bbros-dev
Copy link

bbros-dev commented Mar 4, 2021

Track and report Cucumber-Rust compatibility with upstream 'golden' implementation.

In order to provide this documentation the support code in the upstream Golden master needs to be ported to Rust.... essentially what Cucumber-Rust is - the Golden-Master is the reference implementation.

Related to Gherkin-Rust issues:

@bbqsrc bbqsrc changed the title [Doc] Track and report compatability with upstream 'golden' implementation [Doc] Track and report compatibility with upstream 'golden' implementation Mar 4, 2021
@bbros-dev
Copy link
Author

From this comment, progress awaits upstream PR /cucumber/common/pull/1372
cucumber/common#1372).

running the CCK suite or producing reports. That's an exercise left to the cucumber implementation - run the features from the
CCK with support code equivalent to the example JavaScript ones, and compare the messages that come out with what the
CCK defines (with some normalisation to deal with ids, timestamps etc)

Also:

there are varying approaches between the implementations in terms of how the CCK features and messages are brought in:

  • JavaScript: we publish @cucumber/compatibility-kit to npm and then import that in cucumber-js
  • Java the features and messages are just copied to the cucumber-jvm repo
  • Ruby, last I checked, was linking to the monorepo at a certain tag as a build step.

The current Cucmber-Rust approach is a combination of the JavaScript and Java:

  • The CKK messages and fatures are copied in to Gherkin-Rust (Java)
  • Gherkin-Rust is a separate crate (JavaScript)

IMO this approach is fine.

If we want a CCK report tool we'll have to roll our own.
This issue tracks the existence (or not of a CCK summary/report). Tracking how we get/update that summary in a separate issue.

@bbqsrc bbqsrc closed this as completed Mar 9, 2021
@cucumber-rs cucumber-rs locked and limited conversation to collaborators Mar 9, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants