Add field type slider support #21
Conversation
Filter out BL is outside the scope of this function.
Add mention of slider support. Reformat to satisfy the build checker.
Add shared_testdata folder. Move best makedata.R script for metadata.csv to shared_testdata. Revise tests to use shared_testdata/metadata.csv. Regenerate metadata.csv to from REDCapR input.
Generate max_existing_id when test project is empty.
Generate unique values for each slider. Assume the REDCap defaults for text_validation_min and text_validation_max if they are blank. Localize metadata file used in test and add multiple slider fields. Add test for unique values for each slider.
Don't separate on select_choices_or_calculations as the field is just labels. Calculate the mean of min and max row-wise.
You have a valid point, so I made a shared metadata file and adjusted some tests to use it. Also, the metadata file I said was generated from the REDCap validation types file was modified. I updated the shared metadata file to be exactly what you get out of the REDCapR file. All that said, I found flaws in this function revealed when I challenged it with multiple slider fields. So I couldn't use the shared, vanilla REDCapR metadata file unless I was willing to change the test data for every function. Depending on how I wrote the tests, that might break a lot of tests in one stroke. This is the object argument against shared test data. Each function might have specific needs that require specific test data. I think there are two lessons here:
|
The text in |
|
@ljwoodley please review my changes |
I'm confused by the different metadata file here. Why not use one project/metadata file for all testing and development?
The slider values here in
select_choices_or_calculationsfield are abovetext_validation_max. Am I interpreting that correctly? If so, this makestests/testthat/test-get_long_slider_field_values.Rinvalid.