Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MAGIC+LST-1 performance #28

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support for MAGIC+LST-1 performance #28

wants to merge 6 commits into from

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Oct 25, 2024 •
edited
Loading

This should account for the last update (v1.7 on 2023/11/08) of the legacy script.

I tested is against the legacy script and checked that I get the same values for Crab bin by bin.

HealthyPear added a commit that referenced this pull request Oct 25, 2024
@HealthyPear
Add news fragment for PR #28
a26a38f
HealthyPear added a commit that referenced this pull request Oct 25, 2024
@HealthyPear
Add news fragment for PR #28
227919a
HealthyPear added a commit that referenced this pull request Oct 25, 2024
@HealthyPear
Add news fragment for PR #28
b12ccbd
@HealthyPear HealthyPear added enhancement New feature or request auxiliary data labels Oct 25, 2024
@HealthyPear HealthyPear requested review from jsitarek, SeiyaNozaki and aleberti and removed request for jsitarek October 25, 2024 09:18
HealthyPear added a commit that referenced this pull request Nov 6, 2024
@HealthyPear
Add news fragment for PR #28
6755ec0
@HealthyPear HealthyPear linked an issue Dec 3, 2024 that may be closed by this pull request
Add MAGIC+LST performance tables #27
Open
@aleberti
Copy link

aleberti commented Dec 5, 2024

FYI, Julian added the MAGIC+LST1 performance at high zenith (NB: derived from MC). I send you the link to the MR privately.

@HealthyPear
Copy link
Member Author

FYI, Julian added the MAGIC+LST1 performance at high zenith (NB: derived from MC). I send you the link to the MR privately.

This is not public data, am I correct? The paper
https://www.aanda.org/articles/aa/full_html/2023/12/aa46927-23/aa46927-23.html#S3
goes up to 53 deg

@aleberti
Copy link

aleberti commented Dec 5, 2024

No it is not, but we are planning to ask MAGIC and LST EBs to release them, so that also external people can use them for evaluation, and also because like this we do not need to have a private and public version of the source simulator. So ok, we can wait for the blessings first, then think about including them here too.

@HealthyPear
Copy link
Member Author

by the way #4 is meant to cover exactly this use-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsitarek jsitarek Awaiting requested review from jsitarek

@SeiyaNozaki SeiyaNozaki Awaiting requested review from SeiyaNozaki

@aleberti aleberti Awaiting requested review from aleberti

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
auxiliary data enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MAGIC+LST performance tables
2 participants
@HealthyPear @aleberti