Add support for skymap with planned wobble pointings #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
added
enhancement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
HealthyPear
force-pushed
the
wobble_skymap
branch
2 times, most recently
from
16faa63 to
1390182
Compare
HealthyPear
force-pushed
the
wobble_skymap
branch
from
1390182 to
1418fc1
Compare
HealthyPear
force-pushed
the
wobble_skymap
branch
from
1418fc1 to
a81ae89
Compare
|
One thing that is missing here is the possibility to add an extended source, but I would prefer to do it after #33 so we have the gammapy config file with the sky models |
|
One thing I need to fix is the position angle of the wobbles: I just realized that I am using astropy's convention (0 deg is North and then increase counterclockwise) rather than the IACT convention (0 deg is West and then increase clockwise) easy fix
|
Fix nested quotes plots.wobble_skymap
HealthyPear
force-pushed
the
wobble_skymap
branch
from
a81ae89 to
4521302
Compare
We were using astropy's convention (0 deg is North and then increase counterclockwise) rather than the IACT convention (0 deg is West and then increase clockwise)
|
OK wobble position angle is now fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
Here is an example:
Not super configurable, but a first version.