Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixel order inconsistent in filled containers #182

Open
maxnoe opened this issue May 25, 2023 · 1 comment
Open

pixel order inconsistent in filled containers #182

maxnoe opened this issue May 25, 2023 · 1 comment

Comments

@maxnoe
Copy link
Member

maxnoe commented May 25, 2023

All data comes in the arbitrary module order, which is different from the spiral pattern of increasing pixel ids.

In the source, some fields are re-ordered (e.g. the waveform, calibration info etc.) and some are not.

This inconsistency makes it very hard to know when one has to take expected_pixels_id into account and when not.

We should try to consistently reorder all data or at least document which fields are in the order as received and which are re-ordered to be the ascending pixel id order.

@ccossou
Copy link

ccossou commented Jun 12, 2023

Maybe we could add a filter and sorting method to the data class, to ensure things are done consistently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants