Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better method to deal with the Windows command length limit #194

Open
NiklasRosenstein opened this issue Aug 14, 2018 · 0 comments
Open
Assignees
Milestone

Comments

@NiklasRosenstein
Copy link
Collaborator

The path length limit requires that response files be used with extremely long commands, for example when linking a large number of object files. Currently, a module that generates build operators can explicitly construct a craftr.core.build.Command object and specify that the command supports response files.

At the time the command is executed, the Command.with_response_file() context manager will check if the path length limit is exceeded and alter the specified command list respectively.

The problem with this is portability and extensibility: Some programs may not support response files with the @filename syntax and others may support them only for a subset of their command-line arguments.

Example of current usage in an operator:

https://github.com/craftr-build/craftr/blob/49566dc204c07a12bc51cb360ec981e8026a44eb/src/craftr/stdlib/net.craftr.lang.cxx/impl/base.py#L342-L354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant