Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Main brightness setting #79

Open
ipa64 opened this issue Jul 25, 2021 · 2 comments
Open

[Feature Request] Main brightness setting #79

ipa64 opened this issue Jul 25, 2021 · 2 comments
Labels
request New feature or request

Comments

@ipa64
Copy link

ipa64 commented Jul 25, 2021

Is your feature request related to a problem? Please describe.
No

Could be more useful to have a main brightness setting, that will be applied to all effects unless they have an own defined brightness value (not undef). It could be located in the Node settings (actual name is Connection settings) . In the same time, don't you think {Overrides on/off} setting should be located in Node settings too ? In fact I don't see any raison to have it in effects settings, but maybe I am missing something.
Thank you

Why should this be implemented?
I think the most of case, the brightness value is the same for all effects, so if you want to adjust brightness you need to edit all 10 effects.

Additional context

@cp2004
Copy link
Owner

cp2004 commented Aug 1, 2021

I think that could work, I suppose this would be easier if you want to increase or decrease brightness for all the effects - it could get quite tedious otherwise.

In the same time, don't you think {Overrides on/off} setting should be located in Node settings too ? In fact I don't see any raison to have it in effects settings, but maybe I am missing something.

This setting means that (if it is enabled) when the effect runs, then it will turn the lights on to show the effect. This has to be per-effect, but it doesn't have to be per-segment.

@cp2004 cp2004 added the request New feature or request label Aug 1, 2021
@ipa64
Copy link
Author

ipa64 commented Aug 3, 2021

I suppose this would be easier if you want to increase or decrease brightness for all the effects.

Exacltly

This setting means that (if it is enabled) when the effect runs, then it will turn the lights on to show the effect. This has to be per-effect, but it doesn't have to be per-segment.

In fact I don't understand why a effect should not power on lights ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants