Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some e2e tests fail in this sample #10

Open
gerbenvl opened this issue Oct 18, 2018 · 2 comments
Open

Some e2e tests fail in this sample #10

gerbenvl opened this issue Oct 18, 2018 · 2 comments

Comments

@gerbenvl
Copy link

Hi,

A couple of e2e tests fail when I try to run them:

× should open and view a particular pokemon

  • Failed: No element found using locator: By(css selector, app-modal h1)

× should open and allow arrow keys to navigate between pokemon
- Failed: No element found using locator: By(css selector, app-modal h1)

Running from master from the 98f0bc1 commit (16-10).

Hope you can help out.

Gerben.

@nrevutsky
Copy link

nrevutsky commented Oct 30, 2018

'app-modal h1' should be replaced with 'ngx-modal h1' in test

@gerbenvl
Copy link
Author

Ah thanks! Stupid, missed this. Opened a PR to fix this in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants