Allow vscoqtop.exe in searchForVscoqtopInPath

[cas-haaijman]

When installing vscoq-language-server on Windows machines through an installer like Coq Platform vscoqtop gets installed as vscoqtop.exe. Currently the function searchForVscoqtopInPath only searches for vscoqtop

vscoq/client/src/utilities/toolchain.ts

Line 117 in 26f3f1f

if(await isFileInFolder('vscoqtop', pathVars[i])) {

, so the executable will not be found.

Additionally, the next line

vscoq/client/src/utilities/toolchain.ts

Line 118 in 26f3f1f

return pathVars[i] + '/vscoqtop';

does not use the proper path.delimiter for windows systems.

This could be fixed manually, but maybe it makes sense to use the which package, as both cases are covered by which("vscoqtop"), in trade for an extra import. In my few short experiments, the which package works well with both linux and windows

[rtetley]

Do you perhaps have this change in a branch somewhere ? If so would you mind doing a PR ? :-)

[cas-haaijman]

Do you want a version with which or without? I don't have a branch right now but can make one tomorrow

[rtetley]

Pretty sure using which is fine !

[rtetley]

Closed by #978