Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double voting #139

Closed
dnkolegov opened this issue Jun 1, 2023 · 4 comments
Closed

Double voting #139

dnkolegov opened this issue Jun 1, 2023 · 4 comments
Labels
bug Something isn't working s:ipc-solidity-actors

Comments

@dnkolegov
Copy link
Contributor

The issue is described here - consensus-shipyard/ipc-actors#111

@mikirov
Copy link
Contributor

mikirov commented Jun 12, 2023

With our current design we track the votes of a validator for a given epoch. The problem can be solved by removing the validator votes for the current back to the last executed epoch when they leave so their votes don't persist after they're gone. This solution however requires us to for loop over the previous epochs, which is not optimal in blockchain. Do we still want to go with this approach?

@mikirov
Copy link
Contributor

mikirov commented Jun 12, 2023

If the validator leaves we also have the problem that a different submission than the one he voted for may reach majority. So the whole executable submission logic would need to be re-evaluated on validator leave. This requires fundamental change in the contract logic.

@mikirov
Copy link
Contributor

mikirov commented Jun 12, 2023

What is your take on the isssue @adlrocha ?

@adlrocha adlrocha added the bug Something isn't working label Jul 19, 2023
@adlrocha
Copy link
Contributor

adlrocha commented Oct 4, 2023

In the new implementation of the contracts validators no longer need to vote for checkpoints. @dnkolegov, feel free to reopen if needed.

@adlrocha adlrocha closed this as completed Oct 4, 2023
@jsoares jsoares transferred this issue from consensus-shipyard/ipc-solidity-actors Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s:ipc-solidity-actors
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants