Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD Makefile #542

Open
littlelevi opened this issue Nov 26, 2023 · 2 comments
Open

FreeBSD Makefile #542

littlelevi opened this issue Nov 26, 2023 · 2 comments

Comments

@littlelevi
Copy link

The Makefile for FreeBSD is little bizzare. FreeBSD has its own way to write ports and Makefiles. Here is an example https://cgit.freebsd.org/ports/tree/x11-wm/spectrwm/Makefile
The port is old but I built it minutes ago and I know it compiles and works.
If spectrwm team is willing to support FreeBSD and the port for it, I think the port maintainer and FreeBSD community would not mind and gladly accept the help.

@littlelevi
Copy link
Author

littlelevi commented Nov 26, 2023

I reworked that FreeBSD port Makefile and upgraded it to the newest spectrwm version 3.5.1
The old port is almost 3 years old, and since you keep FreeBSD Makefile this is more proper way to support the OS. The package Maintainer will have less headache (Whoever he may be). So have a copy. I'm not not the port Mainterinar, just provide an update.

Its more tidy, better formated, easier to maintain, less portliner complains, passes make stage and make stage-qa as Porter's Handbook advise. I also made a fix and added missing. spectrwm.desktop file and missing deps for the new version. Compiles on 13.2-RELEASE-p4
But I don't see why it shouldn't work on 14.0 which came out some time ago.

Sorry, github refuses direct file link. I will PR it later

@nunotexbsd
Copy link

Most important than having a config/make for a specific OS or packager, is IMHO, that upstream uses a build setup that complies with standards for *NIX, Gnus, etc.
In this particular case, Makefile should be configurable and flexible that applies to a majority of OSes.

Using a Makefile intrinsic and conneted to a framework is not good. The work on ports configuration should be done by ports maintainers and devs.

Take for example a Makefile from a tool that is being developed in FreeBSD that it is simple and flexible:
https://github.com/johnmehr/gitup/blob/main/Makefile

and gitup port Makefile in other hand:
https://github.com/freebsd/freebsd-ports/blob/main/net/gitup/Makefile

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants