Add support for Kerberos credentials #297
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| String path, | ||
| String what | ||
| ) { | ||
| if (principal == null || principal.isBlank()) { |
There was a problem hiding this comment.
Neither should have embedded double-quotes, else the formatting of sasl.jaas.config in kafkaClientProperties() will be corrupted.
There was a problem hiding this comment.
Yeah. I think double-quotes would have to be escaped.
@Cerchie, thanks for noticing! I hadn't looked into it. I don't think we need to extend the |
thanks! |
This comment has been minimized.
This comment has been minimized.
This reverts commit 944d0c2.
|
I've reverted the commit that added the almost-working integration tests. @flippingbits helped click-test a Quarkus app jar built using this branch against a local Kerberos-enabled CP Kafka environment. However, click-testing with the native executable threw some "method not found" errors. The offending classes will need to be added to the GraalVM reflection configuration. |
Analysis Details0 Issues
Coverage and Duplications
Project ID: ide-sidecar |
Summary of Changes
Completely untested.
Closes #127
The options for Kerberos auth are:
keytab_path(required)principal(required), andservice_name(optional, defaults tokafkaif not provided)Any additional details or context that should be provided?
SR does not support Kerberos as a client auth mechanism, hence
KerberosCredentialsis not included in the spec forschema_registry.credentials.Integration tests for Kerberos auth can be added at a later point (TODO: create issue). For reference, see how librdkafka sets up Kafka environments, using the trivup library.
Pull request checklist
Please check if your PR fulfills the following (if applicable):