Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use libmambapy 2.0.6.rc2 #610

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jjerphan
Copy link

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Signed-off-by: Julien Jerphanion <[email protected]>
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 28, 2025
@jjerphan
Copy link
Author

jjerphan commented Jan 28, 2025

There are errors because the root prefix cannot be determined.

MAMBA_ROOT_PREFIX can be set to do so. Previously it was always set thanks to a profile script wrongly shipped in libmamba, but this changed with mamba-org/mamba#3723.

The error message must be rewritten entirely because this is not clear at all to me.

Now: should we set it instead of the user or not? I still think that the value of MAMBA_ROOT_PREFIX as set by the profile script is wrong if mamba is installed in another environment than the base environment

@jaimergp
Copy link
Contributor

Sure, we can patch it at runtime and set it before importing libmamba (assuming the env var set in os.environ is seen by C++?). I am more intrigued by the need for that value. If it can't be detected, shouldn't the library detect its own location and pick the relevant parent directory? Or even better: should it be specified explicitly as a parameter in the necessary API calls instead of depending on an environment variable?

@jjerphan
Copy link
Author

Currently the location of mamba (which might not be installed) is used to locate the root prefix if the environment variable is not set, but we could use the location of libmamba instead.

@jjerphan jjerphan changed the title test: Use libmambapy 2.0.6.rc1 test: Use libmambapy 2.0.6.rc2 Jan 31, 2025
dev/requirements.txt Outdated Show resolved Hide resolved
jjerphan and others added 3 commits January 31, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants