Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Player IP Address #28

Open
mikldt opened this issue Oct 9, 2014 · 2 comments
Open

Capture Player IP Address #28

mikldt opened this issue Oct 9, 2014 · 2 comments
Assignees

Comments

@mikldt
Copy link
Member

mikldt commented Oct 9, 2014

We should capture the player IP address from the API rather than having the user enter it into the form. The UI should then link to the status and configuration pages on the Bandshell server.

Ideally it would only write to the database when the recorded IP address is nil or different from the reported one.

A bonus might be to check whether it is routable from the server (could be a delayed job). This would be informative to the user and possibly useful down the line in a pseudo-push scenario. In this case we could store some serialized data (address, last updated, and routability) rather than just the address.

@kench
Copy link
Member

kench commented Oct 9, 2014

Can you define routability? Also, do we want to log the external IP address as seen by the server of the IP address the client sees assigned to itself?

@mikldt
Copy link
Member Author

mikldt commented Oct 10, 2014

@kench By routability I mean that the server can make a request to the recorded IP and reach the bandshell server (no NAT or firewalls in the way). I'm leaning towards the IP seen by the server because it's easy to collect. If the two are different, the IP isn't nearly as useful (exception: port forwarding, in which case you want what the server sees).

@mikldt mikldt self-assigned this Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants