Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Foodcritic Issue #7

Closed
computerlyrik opened this issue Feb 17, 2014 · 3 comments
Closed

Fix Foodcritic Issue #7

computerlyrik opened this issue Feb 17, 2014 · 3 comments

Comments

@computerlyrik
Copy link
Owner

FC048: Prefer Mixlib::ShellOut

Recipes source.rb:81

Please have a look how to fix this!

@guilhem
Copy link
Contributor

guilhem commented Feb 17, 2014

working on it: brimworks/lua-zlib#15

@guilhem
Copy link
Contributor

guilhem commented Feb 17, 2014

yes that's quite a long shot, but I try to use "ark" cookbook to kill all useless ressource.
When Makefile will be good (by using a clean make / make install), we will use:

ark "lua zlib" do
  ...
  not_if "lua -e \"require 'zlib'\""
end

Jobs done ;)

@guilhem guilhem mentioned this issue Feb 18, 2014
@computerlyrik
Copy link
Owner Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants