Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IntrinsicWrappers and rely on constprop #387

Open
willtebbutt opened this issue Nov 22, 2024 · 0 comments
Open

Remove IntrinsicWrappers and rely on constprop #387

willtebbutt opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement (performance) Would reduce the time it takes to run some bit of the code low priority

Comments

@willtebbutt
Copy link
Member

See the docstring for Mooncake.IntrinsicsWrappers (once #386 is merged). In short, we misuse Julia's dispatch in the usual way to implement rules for Core.IntrinsicFunctions. Constant propagation has improved greatly since I originally wrote this code, and it might be time to revisit the current decision.
@willtebbutt willtebbutt added low priority enhancement (performance) Would reduce the time it takes to run some bit of the code labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement (performance) Would reduce the time it takes to run some bit of the code low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willtebbutt