Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the MAC OS instruction using nproc #395

Open
faze-geek opened this issue Dec 16, 2024 · 3 comments
Open

Consider changing the MAC OS instruction using nproc #395

faze-geek opened this issue Dec 16, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation to-fix

Comments

@faze-geek
Copy link
Contributor

Description of issue with documention/Way documentation can be improved

I realized this while setting up cppinterop over the weekend.

Kindly go through this memkind/memkind#33

This -->
cmake --build . --target clang clang-repl lld --parallel $(nproc --all)

should be replaced by -->
cmake --build . --target clang clang-repl lld --parallel $(sysctl -n hw.logicalcpu)

And the change needs to be made at multiple places in the documentation.

@faze-geek faze-geek added the documentation Improvements or additions to documentation label Dec 16, 2024
@anutosh491
Copy link
Collaborator

+1

Being a mac user, I myself struggle with this !

@mcbarton
Copy link
Collaborator

mcbarton commented Dec 16, 2024

@faze-geek @anutosh491 I'll make this change. Rather than write out the instructions twice (one for MacOs and one for Linux). I'll create an environment variable ncpus like we do in the cii, and use that.

@vgvassilev
Copy link
Contributor

In theory you can use cmake --build . --target clang clang-repl lld --parallel which will fall back to the default level of job parallelism of your native tool (such as make or ninja). I am not sure but that likely defaults to your number of cpus...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation to-fix
Projects
None yet
Development

No branches or pull requests

4 participants