-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for OSX and Windows #138
Comments
My suggested improvements that could be made to the Github ci workflow for macos are
I know this issue is about ci for Macos and Windows, but my suggested improvements that could be made to the Ubuntu Github ci workflow are
|
That makes sense to me.
We do not need a many core machine for that project. We rely on extensive caching of our llvm builds and that works mostly well.
Do you mean that fail to load as part of the tests? If so, this is our way to check if there was cuda runtime (eg. if there is a cuda gpu).
I joined the waiting list - let's see what happens... |
I was referring to the Github CI, job ubu22-gcc9-clang-repl-16 under 'Build and Test/Install CppInterOp on Unix systems' it fails to load libcudart.so . This is to be expected since they won't have a cuda gpu. I was trying to suggest looking into whether the GPU enabled Github-hosted runners which are in a limited beta have cuda gpus, so that any cuda tests can be run on the Github CI in future. |
I think that once the PR #181 is merged that this issue should be closed, as its about updating the build infrastructure for Windows and osx. Separate issues regarding the ci could be raised instead, such as activate arm builds on ci, adding cppyy Windows builds, etc. |
@vgvassilev According to this PR raised in the runner-images repo actions/runner-images#9179 a Github runner using macos-14 will become available very soon (the latest version). Would you like me to replace the osx13 jobs with an osx14 ones after it becomes available, or add them as separate jobs alongside osx13? |
Probably that’s a good idea. |
@vgvassilev Did this project get access to the non osx arm Github runners in the end after you joined the waiting list? Also the CI is currently failing on the main branch after the wasm CI merge, as it's trying to make use of the llvm build which was made on the main branch, before the merge occurred (this didn't have certain options disable which are incompatible with the wasm build). If you clear the cache it will pass doing the next scheduled CI run. |
I have not heard back from them.
Done! |
Update our build infrastructure to include OSX and Windows builds.
The text was updated successfully, but these errors were encountered: