Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export/import list of images marked as not for upload #6085

Open
nicolas-raoul opened this issue Dec 28, 2024 · 8 comments
Open

Export/import list of images marked as not for upload #6085

nicolas-raoul opened this issue Dec 28, 2024 · 8 comments

Comments

@nicolas-raoul
Copy link
Member

In the custom picker, one can mark some images as not for upload:
Screenshot_20241228-154202.png

Unfortunately this is lost when reinstalling the app.
An import/export feature would be nice to have.

@sonalyadav1
Copy link
Contributor

@nicolas-raoul Could you please clarify where the export/import feature should be implemented in the app for the best user experience?

@parneet-guraya
Copy link
Contributor

We have a #5766 issue where solution covers more broader requirements & this can be one of those too :-)

@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Jan 2, 2025

@sonalyadav1 I would suggest a 3-dots menu here:
Screenshot_20250102-140210~2.png

It would contain 2 items:
"Export checksums of images marked as not for upload" and "Import checksums of images marked as not for upload"

For simpliity, I suggest writing to (and reading from) a hard-coded filename in the user's folder. When importing, if not present, show a helpful message with the full path. If implementing a file choice dialog is not more complex then it is fine too.

The file format: one checksum per line
I believe this should be enough.

@parneet-guraya That other issue is about not losing settings when being logged out, whereas the present issue would be useful to share to other devices. Power users might even want to use that exported file on desktop. But for that other issue you are right that also not losing "marked as not for upload" data when getting logged out would be a huge plus. 🙂

@sonalyadav1
Copy link
Contributor

@nicolas-raoul Thank you for the detailed explanation and suggestions for implementing the feature! I understand the requirements and the suggested implementation steps. Should I proceed with starting work on this feature now ?

@nicolas-raoul
Copy link
Member Author

@sonalyadav1 Yes thanks! 🙂

@sonalyadav1
Copy link
Contributor

Hi @nicolas-raoul ,

I have been working on the implementation of a menu icon for the custom image selector(EXPORT/IMPORT FEATURE). However, I am facing a challenge since the XML file for the main page of the custom selector is shared with the layout inside the folders as well.

Because of this, I am unable to use the status bar for the menu icon specifically for the main page without affecting the folder views.

To address this, I am considering the following approaches:

Using a Conditional Layout: Dynamically adjust the status bar visibility or icon placement based on the context (main page vs. folder view).
Separating Layouts: Create separate XML files for the main page and folder views to have more control over each layout.
Customizing Behavior in Code: Add logic in the activity or fragment to handle the menu icon display based on the current state.
Do you think one of these approaches would work, or would you recommend a different solution?

I apologize for the delay in progress as I was busy for the past week or two. I’ll prioritize this task moving forward.

@nicolas-raoul
Copy link
Member Author

The first approach ("Using a Conditional Layout") sounds ideal.
If difficult, "Customizing Behavior in Code" is OK. :-)
No problem at all, it is not urgent.
Thanks!

@sonalyadav1
Copy link
Contributor

Ok , Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants