Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip over number of search results #8

Open
andreseg opened this issue Oct 11, 2021 · 5 comments
Open

Tooltip over number of search results #8

andreseg opened this issue Oct 11, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andreseg
Copy link
Contributor

hovering over the # of search results should show tooltip w/:

  • Tab to see next result
  • Shift Tab to see next result

image

@andreseg andreseg added enhancement New feature or request good first issue Good for newcomers labels Oct 11, 2021
@andreseg
Copy link
Contributor Author

@adlerfaulkner want to respond to this?

@adlerfaulkner
Copy link
Member

adlerfaulkner commented Oct 15, 2021

@andreseg Sure!
@izhar360 Welcome! Thanks for contributing.

The code which displays the number of search results and the currently selected result as shown in the image above exists in matches_summary.js.

To add a tooltip to it, you can use the <Tooltip> component defined in tooltip.js. You can see an example of how <Tooltip> is used in visibility_button.js. You can actually use a lot of the same styling as visibility_button.js uses for the content rendered inside the tooltip. The css styling is in content.css.

@izhar360 izhar360 removed their assignment Oct 17, 2021
@izhar360
Copy link

I am so sorry guys I am working on a project and its very hard to get time for this right now, I'll check this sometime sooner. Sorry again.

@ghost
Copy link

ghost commented Oct 29, 2021

I'd be happy to work on this :D Just found the extension 👍🏻 Nice stuff ^^

@adlerfaulkner
Copy link
Member

Thanks @Liberatys. Please let me know how I can support you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants