Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show "Convert Video" action under portal_actions for Audio objects #27

Open
neilferreira opened this issue Nov 12, 2015 · 2 comments
Open

Do not show "Convert Video" action under portal_actions for Audio objects #27

neilferreira opened this issue Nov 12, 2015 · 2 comments

Comments

@neilferreira
Copy link

Currently the Audio objects have a Convert Audio link which simply errors because of a missing video attribute.

I have fixed this by doing: https://github.com/neilferreira/wildcard.media/commit/95547c1f611f4e9f8885bbeab6baec6b5d0b5a61
@neilferreira
Copy link
Author

I just realized that because I removed the actual method from the Utils class that it would break any existing sites that update their version without re-installing the addon.

@vangheem
Copy link
Member

Maybe just leave the method there, add a deprecation note and provide an upgrade step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vangheem @neilferreira