Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate core-service and task-service? #17

Closed
dcgoss opened this issue Jul 10, 2017 · 3 comments
Closed

Consolidate core-service and task-service? #17

dcgoss opened this issue Jul 10, 2017 · 3 comments

Comments

@dcgoss
Copy link
Member

dcgoss commented Jul 10, 2017

Looking through the codebases, I keep wondering whether we could transfer task-service as an app to the core-service repo. Is it really necessary to run two separate django servers and databases for core-service and task-service? Wondering what y'all think. Tagging @dhimmel @awm33

@dhimmel
Copy link
Member

dhimmel commented Jul 11, 2017

@dcgoss I don't have a strong opinion. I believe @awm33 saw benefits to a having a separate service. But I'll defer to you what the best way forward is.

@awm33
Copy link
Member

awm33 commented Jul 11, 2017

@dcgoss @dhimmel There can be benefits to a separate service if the project grew much larger in scope. But given the projects progression over the last year, I think it's safe to combine them. Since there's a 1:1 ratio between classifiers and tasks, you could even just move the task management columns directly over to the classifier table.

@dcgoss
Copy link
Member Author

dcgoss commented Jul 12, 2017

Planning to go ahead with the consolidation. See cognoma/core-service#73 and cognoma/core-service#74.

@dcgoss dcgoss closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants