From c6e2fc4acbd07078097c7b62053fdffc6d80ada9 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Wed, 20 Apr 2022 19:57:50 -0500 Subject: [PATCH] fix gha reviewdog workflow so it actually uses go 1.17 it was installing 1.18 which can panic or have a variety of silent failures. See: https://github.com/reviewdog/action-golangci-lint/issues/249 --- .github/workflows/reviewdog.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 1e0515d0..38314fc9 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -5,6 +5,10 @@ name: reviewdog on: pull_request: +# NOTE: We have to specify `go_version: 1.17` because the action was installing 1.18. +# 1.18, in turn, is not fully supported by golangci-lint yet, and it can fail silently: +# see: https://github.com/reviewdog/action-golangci-lint/issues/249 + # pipeline to execute jobs: diff-review: @@ -19,6 +23,7 @@ jobs: uses: reviewdog/action-golangci-lint@v2 with: github_token: ${{ secrets.github_token }} + go_version: 1.17 golangci_lint_flags: "--config=.golangci.yml" fail_on_error: true filter_mode: diff_context @@ -36,6 +41,7 @@ jobs: uses: reviewdog/action-golangci-lint@v2 with: github_token: ${{ secrets.github_token }} + go_version: 1.17 golangci_lint_flags: "--config=.golangci.yml" fail_on_error: false filter_mode: nofilter