You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current guide for the space before function parentheses doesn't seem to align with any major style guides, such as Google Style Guide or Airbnb Style Guide.
I propose to clarify it in the description and to change eslint configuration of the corresponding rule to following:
Additionally, instead of creating our own style guide we can just use one of those I described on top ☝️ that have good documentation. I personally prefer: Airbnb style guide, but I'm happy to work with any recommended guides as long as it doesn't force me to put whitespace before named function parentheses.
The text was updated successfully, but these errors were encountered:
Yeh, this is a massive pain and makes me just switch off linting when I'm doing any reviews.
Frankly I don't think we should be linting code formatting at all. Prettier exists, there's no reason not to use it. We should update the eslint configs to use the eslint-prettier plugin https://prettier.io/docs/en/integrating-with-linters.html and just provide both as dev dependencies.
Current guide for the space before function parentheses doesn't seem to align with any major style guides, such as Google Style Guide or Airbnb Style Guide.
I propose to clarify it in the description and to change
eslint
configuration of the corresponding rule to following:Additionally, instead of creating our own style guide we can just use one of those I described on top ☝️ that have good documentation. I personally prefer: Airbnb style guide, but I'm happy to work with any recommended guides as long as it doesn't force me to put whitespace before named function parentheses.
The text was updated successfully, but these errors were encountered: