Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconventional space-before-function-paren #3

Open
snigo opened this issue Nov 19, 2020 · 1 comment · May be fixed by #4
Open

Unconventional space-before-function-paren #3

snigo opened this issue Nov 19, 2020 · 1 comment · May be fixed by #4

Comments

@snigo
Copy link

snigo commented Nov 19, 2020

Current guide for the space before function parentheses doesn't seem to align with any major style guides, such as Google Style Guide or Airbnb Style Guide.

I propose to clarify it in the description and to change eslint configuration of the corresponding rule to following:

"space-before-function-paren": { "anonymous": "always", "named": "never", "asyncArrow": "always" }

Additionally, instead of creating our own style guide we can just use one of those I described on top ☝️ that have good documentation. I personally prefer: Airbnb style guide, but I'm happy to work with any recommended guides as long as it doesn't force me to put whitespace before named function parentheses.

@AlexKMarshall
Copy link

Yeh, this is a massive pain and makes me just switch off linting when I'm doing any reviews.

Frankly I don't think we should be linting code formatting at all. Prettier exists, there's no reason not to use it. We should update the eslint configs to use the eslint-prettier plugin https://prettier.io/docs/en/integrating-with-linters.html and just provide both as dev dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants