From 6c2d1642f3f5e86cd54d225398b1401184aabc4d Mon Sep 17 00:00:00 2001 From: Adrian Date: Tue, 30 Apr 2024 11:11:47 -0600 Subject: [PATCH] final tweak based on PR comments --- tasks/backfill_existing_gh_app_installations.py | 1 - tasks/backfill_owners_without_gh_app_installations.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tasks/backfill_existing_gh_app_installations.py b/tasks/backfill_existing_gh_app_installations.py index 7ba635719..ea472b68a 100644 --- a/tasks/backfill_existing_gh_app_installations.py +++ b/tasks/backfill_existing_gh_app_installations.py @@ -69,7 +69,6 @@ def backfill_existing_gh_apps( gh_app_installation=gh_app_installation, ) log.info("Successful backfill", extra=dict(ownerid=ownerid)) - del owner_service except: log.info( "Backfill unsuccessful for this owner", extra=dict(ownerid=ownerid) diff --git a/tasks/backfill_owners_without_gh_app_installations.py b/tasks/backfill_owners_without_gh_app_installations.py index 42e0e00ca..59de447a2 100644 --- a/tasks/backfill_owners_without_gh_app_installations.py +++ b/tasks/backfill_owners_without_gh_app_installations.py @@ -72,7 +72,7 @@ def backfill_owners_with_integration_without_gh_app( name=GITHUB_APP_INSTALLATION_DEFAULT_NAME, ) db_session.add(gh_app_installation) - db_session.commit() + # db_session.commit() is_selection_all = maybe_set_installation_to_all_repos( db_session=db_session,