-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this production ready? #7
Comments
Hi, that's the only thing left, gonna push the logout functionality soon, but when dealing with JWT, logout means blacklisting a token |
Oh great! Was looking for a simpler JWT package. Thanks! |
I just found this repo as well and would love to give it a fair shot. Is there an ETA of getting the logout functionality working? |
Hey guys, I'm using it on production, apart from blacklisting tokens, the rest of the functionalities are just helpers for you to plug on the controllers. Thank you guys for the support. |
Sounds good. As I look into using this package, If i require "blacklisting" you may have a pull request to look at 👍 |
Starting to work on the blacklisting now. It will be done by a caching, instead of storage. Any ideas, feel free to contribute. Thank you all! |
Next time don't believe me, not even I remembered I was pending on this. |
BTW, just noticing the title here, please take my advice when looking at software: OSS is just OSS, production ready is just a marketing term people put on landing pages to win flame wars. OSS is never production ready because there are no warranties, of any kind. Understand open source software you plug on your projects because when it comes to it, you're the only one accountable. |
"Software is never Production Ready" is the sign of a coding amateur. All of my packages, when they reach v1.0 and have 100% automated test code coverage, are ready for production. And I'll stake my professional reputation on them behaving correctly. I've run into this exact same problem with |
Was looking for a Tymon JWT alternative and found this repo. Looks nice but noticed, for example, that logout functionality is not implemented. So I was wondering if this repo is ready for production or are there any other unknown unfinished parts? Thanks.
The text was updated successfully, but these errors were encountered: