Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load images directly where they are used #32

Open
tjwelde opened this issue Mar 7, 2018 · 1 comment
Open

Load images directly where they are used #32

tjwelde opened this issue Mar 7, 2018 · 1 comment
Assignees
Labels
refactor Tracking tickets relating to refactoring

Comments

@tjwelde
Copy link
Collaborator

tjwelde commented Mar 7, 2018

Right now, all images are loaded in the index.jsx file. We can move this logic to the OneImage component, which will get the images from gaia on mount. The component will just get the image path as property.

@tjwelde tjwelde added the refactor Tracking tickets relating to refactoring label Mar 7, 2018
@benpbenp
Copy link
Collaborator

benpbenp commented Mar 8, 2018

I think this is a nice easy win for separation of concerns while still keeping a single place (index.jsx) for application state for the time being.

We need a username prop in addition to the path prop though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Tracking tickets relating to refactoring
Projects
None yet
Development

No branches or pull requests

2 participants