Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Add support for other networks besides .cms #104

Open
Phil2812 opened this issue Nov 10, 2017 · 3 comments · May be fixed by #106
Open

Add support for other networks besides .cms #104

Phil2812 opened this issue Nov 10, 2017 · 3 comments · May be fixed by #106

Comments

@Phil2812
Copy link
Collaborator

The DAQAggregator assumes hostnames to end with .cms in some places:

https://github.com/cmsdaq/DAQAggregator/search?l=Java&q=%22.cms%22&type=&utf8=%E2%9C%93

This caused problems in the setup for 904 and a solution for supporting at least .cms and .cms904 should be found.

@andreh12
Copy link
Contributor

I would suggest to first merge #101 and then #103 before we fix this (unless there is some urgency or #101 can't be merged soon).

Many of the occurrences appear in tests -- I suggest that we first fix the ones in src/main .

@Phil2812
Copy link
Collaborator Author

Phil2812 commented Nov 13, 2017

There is a modified version of the aggregator running at 904 since Friday, so fixing this is not particularly urgent. To create this version, I simply replaced .cms with .cms904 in all the Java classes in src/main/**.

How do you propose to solve this? Do you intend to make the network a configurable option or simply create a list of supported networks? The problem with the second solution would be that the aggregator also appends the ".cms" suffix to hosts [1]. Supporting multiple TLDs at the same time would make it impossible for the aggregator to know which TLD to append (without further changes).

[1]

@andreh12
Copy link
Contributor

I guess then we should make it configurable from DAQAggregator.properties

@andreh12 andreh12 linked a pull request Nov 22, 2017 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants