diff --git a/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHGCalIDVarProducer.cc b/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHGCalIDVarProducer.cc index 66b1758f65fb4..0b68ea7cd4d14 100644 --- a/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHGCalIDVarProducer.cc +++ b/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHGCalIDVarProducer.cc @@ -64,8 +64,7 @@ EgammaHLTHGCalIDVarProducer::EgammaHLTHGCalIDVarProducer(const edm::ParameterSet consumes(config.getParameter("recoEcalCandidateProducer"))), hgcalRecHitToken_(consumes(config.getParameter("hgcalRecHits"))), layerClusterToken_(consumes(config.getParameter("layerClusters"))), - ssCalc_(consumesCollector()) -{ + ssCalc_(consumesCollector()) { pcaAssocMaps_.emplace_back(PCAAssocMap(&HGCalShowerShapeHelper::ShowerWidths::sigma2xx, "sigma2xx")); pcaAssocMaps_.emplace_back(PCAAssocMap(&HGCalShowerShapeHelper::ShowerWidths::sigma2yy, "sigma2yy")); pcaAssocMaps_.emplace_back(PCAAssocMap(&HGCalShowerShapeHelper::ShowerWidths::sigma2zz, "sigma2zz")); diff --git a/RecoEgamma/EgammaHLTProducers/plugins/HLTHGCalLayerClusterIsolationProducer.cc b/RecoEgamma/EgammaHLTProducers/plugins/HLTHGCalLayerClusterIsolationProducer.cc index 69620865cb684..483c419b57db1 100644 --- a/RecoEgamma/EgammaHLTProducers/plugins/HLTHGCalLayerClusterIsolationProducer.cc +++ b/RecoEgamma/EgammaHLTProducers/plugins/HLTHGCalLayerClusterIsolationProducer.cc @@ -34,7 +34,6 @@ #include "RecoEgamma/EgammaTools/interface/HGCalClusterTools.h" - template class HLTHGCalLayerClusterIsolationProducer : public edm::stream::EDProducer<> { typedef std::vector T1Collection; @@ -69,7 +68,8 @@ class HLTHGCalLayerClusterIsolationProducer : public edm::stream::EDProducer<> { template HLTHGCalLayerClusterIsolationProducer::HLTHGCalLayerClusterIsolationProducer(const edm::ParameterSet& config) - : layerClusterProducer_(consumes(config.getParameter("layerClusterProducer"))), + : layerClusterProducer_( + consumes(config.getParameter("layerClusterProducer"))), rhoProducer_(consumes(config.getParameter("rhoProducer"))), drMax_(config.getParameter("drMax")), drVetoEM_(config.getParameter("drVetoEM")), @@ -85,7 +85,8 @@ HLTHGCalLayerClusterIsolationProducer::HLTHGCalLayerClusterIsolationProducer effectiveAreas_(config.getParameter>("effectiveAreas")) { if (doRhoCorrection_) { if (effectiveAreas_.size() != 2) - throw cms::Exception("IncompatibleVects") << "effectiveAreas should have two elements for em and had components. \n"; + throw cms::Exception("IncompatibleVects") + << "effectiveAreas should have two elements for em and had components. \n"; } std::string recoCandidateProducerName = "recoCandidateProducer"; @@ -134,7 +135,7 @@ void HLTHGCalLayerClusterIsolationProducer::produce(edm::Event& iEvent, cons rho = *(rhoHandle.product()); } - rho = std::min(rho,rhoMax_); + rho = std::min(rho, rhoMax_); rho = rho * rhoScale_; edm::Handle recoCandHandle; @@ -152,19 +153,25 @@ void HLTHGCalLayerClusterIsolationProducer::produce(edm::Event& iEvent, cons for (unsigned int iReco = 0; iReco < recoCandHandle->size(); iReco++) { T1Ref candRef(recoCandHandle, iReco); - float sumEm = HGCalClusterTools::emEnergyInCone(candRef->eta(), candRef->phi(), - layerClusters, - drVetoEM_, drMax_, - minEtEM_, minEnergyEM_, - useEt_ ? HGCalClusterTools::EType::ET : - HGCalClusterTools::EType::ENERGY ); - - float sumHad = HGCalClusterTools::hadEnergyInCone(candRef->eta(), candRef->phi(), - layerClusters, - drVetoHad_, drMax_, - minEtHad_, minEnergyHad_, - useEt_ ? HGCalClusterTools::EType::ET : - HGCalClusterTools::EType::ENERGY ); + float sumEm = + HGCalClusterTools::emEnergyInCone(candRef->eta(), + candRef->phi(), + layerClusters, + drVetoEM_, + drMax_, + minEtEM_, + minEnergyEM_, + useEt_ ? HGCalClusterTools::EType::ET : HGCalClusterTools::EType::ENERGY); + + float sumHad = + HGCalClusterTools::hadEnergyInCone(candRef->eta(), + candRef->phi(), + layerClusters, + drVetoHad_, + drMax_, + minEtHad_, + minEnergyHad_, + useEt_ ? HGCalClusterTools::EType::ET : HGCalClusterTools::EType::ENERGY); if (doRhoCorrection_) { sumEm = sumEm - rho * effectiveAreas_.at(0); @@ -179,8 +186,8 @@ void HLTHGCalLayerClusterIsolationProducer::produce(edm::Event& iEvent, cons } iEvent.put(std::make_unique(recoCandMap)); - iEvent.put(std::make_unique(recoCandMapEm),"em"); - iEvent.put(std::make_unique(recoCandMapHad),"had"); + iEvent.put(std::make_unique(recoCandMapEm), "em"); + iEvent.put(std::make_unique(recoCandMapHad), "had"); } typedef HLTHGCalLayerClusterIsolationProducer EgammaHLTHGCalLayerClusterIsolationProducer; diff --git a/RecoEgamma/EgammaTools/interface/HGCalShowerShapeHelper.h b/RecoEgamma/EgammaTools/interface/HGCalShowerShapeHelper.h index eee6488e84fd4..31547a05dbd1f 100644 --- a/RecoEgamma/EgammaTools/interface/HGCalShowerShapeHelper.h +++ b/RecoEgamma/EgammaTools/interface/HGCalShowerShapeHelper.h @@ -44,7 +44,6 @@ #include "RecoParticleFlow/PFClusterProducer/interface/InitialClusteringStepBase.h" class HGCalShowerShapeHelper { - // Good to filter/compute/store this stuff beforehand as they are common to the shower shape variables. // No point in filtering, computing layer-wise centroids, etc. for each variable again and again. // Once intitialized, one can the calculate different variables one after another for a given object. @@ -127,7 +126,6 @@ class HGCalShowerShapeHelper { ROOT::Math::XYZVector centroid_; std::vector layerEnergies_; std::vector layerCentroids_; - }; #endif