Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require requests==2.7.0 #110

Closed
florianm opened this issue Jul 7, 2015 · 2 comments
Closed

require requests==2.7.0 #110

florianm opened this issue Jul 7, 2015 · 2 comments

Comments

@florianm
Copy link

florianm commented Jul 7, 2015

Could the required version of requests be updated to the currently latest 2.7.0? I've tried that on my end without running in to any troubles. From reading request's change logs, no breaking changes or backwards-incompatibilities have been introduced since 1.1.0.
Happy to submit PR if appropriate.
@florianm
Copy link
Author

florianm commented Oct 9, 2015

as discussed with @amercader at ckan/ckan-service-provider/pull/30, ckan pins requests==2.3.0, so I'll suggest either letting requests float here, as ckanext-spatial will almost always come with ckan. This is not urgent however.

@davidread
Copy link
Contributor

This was fixed a few weeks ago to allow 2.7.0: pip-requirements.txt has requests>=1.1.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidread @florianm