From faf92a942691ba78551b123b8e7d90c3c2bf465d Mon Sep 17 00:00:00 2001 From: John Clary Date: Thu, 20 Aug 2020 00:03:18 -0500 Subject: [PATCH 1/4] bump --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 3cf21eb..fe3bcca 100644 --- a/setup.py +++ b/setup.py @@ -46,7 +46,7 @@ def build_config(env, readme="README.md"): "packages": ["knackpy"], "tests_require": ["pytest", "coverage"], "url": "http://github.com/cityofaustin/knackpy", - "version": "1.0.10", + "version": "1.0.11", } From cc50727ac5c43e52c97d405f6a674ee37cfbc1a8 Mon Sep 17 00:00:00 2001 From: John Clary Date: Thu, 20 Aug 2020 00:03:37 -0500 Subject: [PATCH 2/4] correctly handle a nonetype case --- knackpy/record.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/knackpy/record.py b/knackpy/record.py index 9712aa8..3cfbc9e 100644 --- a/knackpy/record.py +++ b/knackpy/record.py @@ -23,9 +23,7 @@ def __init__(self, data, field_defs, identifier, timezone): self.immutable = True def __repr__(self): - identifier_value = self.data[self.identifier] - # if the identifier field has no value, use the record ID - identifier_value = identifier_value if identifier_value else self.data["id"] + identifier_value = self.data[self.identifier] if self.identifier else self.data["id"] return f"" def __getitem__(self, client_key): From 15f5d25911320e4e747a0f417457cb151076b79c Mon Sep 17 00:00:00 2001 From: John Clary Date: Thu, 20 Aug 2020 00:05:09 -0500 Subject: [PATCH 3/4] update silly coverage badge --- coverage.svg | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/coverage.svg b/coverage.svg index 6963b3e..607d3de 100644 --- a/coverage.svg +++ b/coverage.svg @@ -9,13 +9,13 @@ - + coverage coverage - 87% - 87% + 91% + 91% From 6dafd4bc7676ef4dfafa5550c2facb46b86e5dd8 Mon Sep 17 00:00:00 2001 From: John Clary Date: Thu, 20 Aug 2020 00:05:26 -0500 Subject: [PATCH 4/4] add -f to coverage-badge command --- docs/developer_guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer_guide.md b/docs/developer_guide.md index 8d181ad..6009391 100644 --- a/docs/developer_guide.md +++ b/docs/developer_guide.md @@ -51,7 +51,7 @@ After running the tests, you can use `$ coverage html` to generate HTML document You can update the coverage badge image with: ```bash -$ coverage-badge -o coverage.svg +$ coverage-badge -f -o coverage.svg ``` ## Linting and Formatting