Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After the commit 986bd65b7111, decoding frequently fails with error. #3705

Closed
tyan0 opened this issue Dec 1, 2023 · 1 comment
Closed

After the commit 986bd65b7111, decoding frequently fails with error. #3705

tyan0 opened this issue Dec 1, 2023 · 1 comment

Comments

@tyan0
Copy link
Contributor

tyan0 commented Dec 1, 2023

After the commit 986bd65, decoding frequently fails with the error like:
[OpenH264] this = 0x0xa0010d6b0, Error:DecodeCurrentAccessUnit()::::::PrefetchPic ERROR, pSps->iNumRefFrames:3.

This caused if iPicBuffIdx is zero at:
986bd65#diff-089ebaf0325c2c30af67611943308f0621afbceb64450c668961b6bd1561b43fR1137

I think this line should be
if (iPicBuffIdx >= 0 && iPicBuffIdx < pPicBuff->iCapacity)
rather than
if (iPicBuffIdx > 0 && iPicBuffIdx < pPicBuff->iCapacity)
.

I hope this bug would be fixed in the next release.
@tyan0
Copy link
Contributor Author

tyan0 commented Dec 1, 2023

Ah, sorry. This will be fixed by existing PR #3704.

@tyan0 tyan0 changed the title After the commit 986bd65b7111, decoding sometimes fails with error. After the commit 986bd65b7111, decoding frequently fails with error. Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tyan0 @BenzhengZhang